Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Track.AdditionalFields.Clear() reporting false "key not found" warnings at save time #316

Open
kitsumed opened this issue Feb 13, 2025 · 1 comment

Comments

@kitsumed
Copy link
Contributor

File Type : mp3
Format : ID3v2

*Note (Same sample file as #315, can resend if needed)

Issue:
When saving the new metadata after calling Track.AdditionalFields.Clear() ATL does remove all of the fields (TXXX in this case) but also throw warnings in the console for each key name that read out as 'Field code [KEY-NAME-HERE] cannot be deleted because it has not been found on current TagData.'. LOCATION : 'C:\Users\<hidden>\AppData\Local\Temp\file.mp3'. Warning that does not make sense as all of the key where still deleted.

Sample code:

// Load the file in ATL
Track audioTrack = new Track("file.mp3");
audioTrack.AdditionalFields?.Clear();
bool wasNewMetadataApplyed = await audioTrack.SaveAsync(); // Warnings are reported here

*Require that the ATL loggers delegate is configured to see the warnings

@Zeugma440 Zeugma440 self-assigned this Feb 14, 2025
@Zeugma440 Zeugma440 added the bug label Feb 14, 2025
@Zeugma440
Copy link
Owner

Thanks for your feedback. This is a specific issue that arises when ATL rewrites tagging systems that have a fixed set of fields and therefore do not support additional fields (in that case : ID3v1).

There's no actual problem; these messages shouldn't even show up.

=> Fixed for next release ✅

Zeugma440 added a commit that referenced this issue Feb 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants