Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve the useabilty of Selection Sort program #16

Open
Zircoz opened this issue Oct 11, 2019 · 9 comments
Open

Improve the useabilty of Selection Sort program #16

Zircoz opened this issue Oct 11, 2019 · 9 comments
Labels
enhancement New feature or request hacktoberfest Fit for newbies to hacktober fest and open source contributions

Comments

@Zircoz
Copy link
Owner

Zircoz commented Oct 11, 2019

The code written in #12 takes an array of numbers seperated by whitespaces. If anyone can make it more 'user-friendly' it will be great!

Please explain how your changes make the existing code better.

@Zircoz Zircoz changed the title Imrpove the useabilty Improve the useabilty of Selection Sort program Oct 11, 2019
@Zircoz Zircoz added enhancement New feature or request good first issue Good for newcomers hacktoberfest Fit for newbies to hacktober fest and open source contributions up-for-grabs labels Oct 11, 2019
@simonbukin
Copy link

The selection_sort function itself looks functionally correct to me, what exactly do you mean by "user-friendly"? It looks like the function just takes a list as input, so the input that goes into it needs to be changed I'm assuming?

@Zircoz
Copy link
Owner Author

Zircoz commented Oct 12, 2019

Yeah, I would image an easier way of entering the numbers, like one by one. Or something you can think of.

@simonbukin
Copy link

Maybe it would be a good idea to implement testing? Something like pytest would let us make sure all the algorithms in the repo are functional on a variety of input.

I'm still not entirely sure what you mean by adding easier number input, but it looks like the file was changed in #17 . Is that more what you were looking for?

@dwijenchawra
Copy link

I'd like to work on this!

@anirudhbagri
Copy link

Can you check #23, if this is what we wanted..

@dwijenchawra
Copy link

I have already resolved this issue... https://github.com/Zircoz/Sorting-Algorithms-in-Python/pull/21#issue-327618293

@Zircoz
Copy link
Owner Author

Zircoz commented Oct 19, 2019

Both solutions are pretty similar, @dwijenchawra & @anirudhbagri .
I will merge Chawra's PR when it is approved based on first come first serve basis.

@Zircoz
Copy link
Owner Author

Zircoz commented Oct 19, 2019

Yes, @simonbcodes testing implementation sounds good to me and it can be a separate issue of its own but I am not familiar with it yet. So, I will try it in local sandbox and get back to this when I am ready and have enough time.

@Zircoz
Copy link
Owner Author

Zircoz commented Oct 19, 2019

Both solutions are pretty similar, @dwijenchawra & @anirudhbagri .
I will merge Chawra's PR when it is approved based on first come first serve basis.

I just discovered the #20 and it provides better usability while giving almost similar way of ending array as @dwijenchawra and @anirudhbagri 's. So, it is being merged and thanks to everyone else who contributed to this issue. Feel free to even improve it even further in any direction.

@Zircoz Zircoz removed good first issue Good for newcomers up-for-grabs labels Oct 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request hacktoberfest Fit for newbies to hacktober fest and open source contributions
Projects
None yet
Development

No branches or pull requests

4 participants