-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve the useabilty of Selection Sort program #16
Comments
The selection_sort function itself looks functionally correct to me, what exactly do you mean by "user-friendly"? It looks like the function just takes a list as input, so the input that goes into it needs to be changed I'm assuming? |
Yeah, I would image an easier way of entering the numbers, like one by one. Or something you can think of. |
Maybe it would be a good idea to implement testing? Something like pytest would let us make sure all the algorithms in the repo are functional on a variety of input. I'm still not entirely sure what you mean by adding easier number input, but it looks like the file was changed in #17 . Is that more what you were looking for? |
I'd like to work on this! |
Can you check #23, if this is what we wanted.. |
I have already resolved this issue... |
Both solutions are pretty similar, @dwijenchawra & @anirudhbagri . |
Yes, @simonbcodes testing implementation sounds good to me and it can be a separate issue of its own but I am not familiar with it yet. So, I will try it in local sandbox and get back to this when I am ready and have enough time. |
I just discovered the #20 and it provides better usability while giving almost similar way of ending array as @dwijenchawra and @anirudhbagri 's. So, it is being merged and thanks to everyone else who contributed to this issue. Feel free to even improve it even further in any direction. |
The code written in #12 takes an array of numbers seperated by whitespaces. If anyone can make it more 'user-friendly' it will be great!
Please explain how your changes make the existing code better.
The text was updated successfully, but these errors were encountered: