Fix activate deals for NV22 (#508)

* feat: allow nil activations and use failcodes

* test: add activate deals test

* test: add test case

Author: ziscky

tools/deals/activations.go

@@ -15,6 +15,9 @@ import (
 const (
 	KeySectors              = "Sectors"
 	KeyActivations          = "Activations"
+	KeyActivationResults    = "ActivationResults"
+	KeyFailCodes            = "FailCodes"
+	KeyIdx                  = "Idx"
 	KeyDealWeight           = "DealWeight"
 	KeyVerifiedDealWeight   = "VerifiedDealWeight"
 	KeyNonVerifiedDealSpace = "NonVerifiedDealSpace"
@@ -239,15 +242,35 @@ func (eg *eventGenerator) parseActivateDeals(tx *types.Transaction, params, ret
 	if err != nil {
 		return nil, nil, err
 	}
-	activations, err := common.GetSlice[map[string]interface{}](ret, KeyActivations, false)
+	// activations can be nil if all activations failed
+	activations, err := common.GetSlice[map[string]interface{}](ret, KeyActivations, true)
 	if err != nil {
 		return nil, nil, err
 	}
-	if len(sectorDeals) != len(activations) {
-		return nil, nil, fmt.Errorf("sectorDeals and activations have different lengths: sectorDeals(%d) != activations(%d)", len(sectorDeals), len(activations))
+
+	activationResults, err := common.GetItem[map[string]interface{}](ret, KeyActivationResults, true)
+	if err != nil {
+		return nil, nil, err
+	}
+	failedActivations := map[int64]bool{}
+	if len(activationResults) > 0 {
+		failCodes, err := common.GetSlice[map[string]interface{}](activationResults, KeyFailCodes, true)
+		if err != nil {
+			return nil, nil, err
+		}
+		for _, failCode := range failCodes {
+			idx, err := common.GetInteger[int64](failCode, KeyIdx, false)
+			if err != nil {
+				return nil, nil, err
+			}
+			failedActivations[idx] = true
+		}
 	}
 
 	for i := range sectorDeals {
+		if failedActivations[int64(i)] {
+			continue
+		}
 		if err := parseDeals(sectorDeals[i], activations[i]); err != nil {
 			return nil, nil, err
 		}

tools/deals/deals_test.go

@@ -148,3 +148,88 @@ func TestParseVerifyDealsForActivation(t *testing.T) {
 		})
 	}
 }
+
+func TestActivateDeals(t *testing.T) {
+	eg := setupTest(t, "mainnet")
+
+	tests := []struct {
+		name     string
+		txType   string
+		txFrom   string
+		txTo     string
+		metadata string
+		height   uint64
+	}{
+
+		{
+			name:     "NV3",
+			txType:   parser.MethodActivateDeals,
+			txFrom:   txFrom,
+			txTo:     txTo,
+			metadata: `{"MethodNum":"6","Params":{"DealIDs":null,"SectorExpiry":1646434}}`,
+			height:   94000,
+		},
+		{
+			name:     "NV10",
+			txType:   parser.MethodActivateDeals,
+			txFrom:   txFrom,
+			txTo:     txTo,
+			metadata: `{"MethodNum":"6","Params":{"DealIDs":[1596649,1596648],"SectorExpiry":1079530}}`,
+			height:   550367,
+		},
+		{
+			name:     "NV17",
+			txType:   parser.MethodActivateDeals,
+			txFrom:   txFrom,
+			txTo:     txTo,
+			metadata: `{"MethodNum":"6","Params":{"DealIDs":[17507589],"SectorExpiry":3937912}}`,
+			height:   2383680,
+		},
+		{
+			name:     "NV22 - null activations",
+			txType:   parser.MethodActivateDeals,
+			txFrom:   txFrom,
+			txTo:     txTo,
+			metadata: `{"MethodNum":"6","Params":{"Sectors":[{"SectorNumber":5868,"SectorType":8,"SectorExpiry":5388210,"DealIDs":[79175167]}],"ComputeCID":false},"Return":{"ActivationResults":{"SuccessCount":0,"FailCodes":[{"Idx":0,"Code":16}]},"Activations":null}}`,
+			height:   3857557,
+		},
+		{
+			name:     "NV22",
+			txType:   parser.MethodActivateDeals,
+			txFrom:   txFrom,
+			txTo:     txTo,
+			metadata: `{"MethodNum":"6","Params":{"Sectors":[{"SectorNumber":37656,"SectorType":8,"SectorExpiry":4920235,"DealIDs":[78950968]},{"SectorNumber":37888,"SectorType":8,"SectorExpiry":4920235,"DealIDs":[78951195]},{"SectorNumber":37549,"SectorType":8,"SectorExpiry":4920235,"DealIDs":[79166044]}],"ComputeCID":false},"Return":{"ActivationResults":{"SuccessCount":3,"FailCodes":null},"Activations":[{"NonVerifiedDealSpace":"0","VerifiedInfos":[{"Client":3061409,"AllocationId":61239862,"Data":{"/":"baga6ea4seaqgvrjfj65lawcocwvrpgq7h53oghvto6akrys6wllhbbckchfgefy"},"Size":34359738368}],"UnsealedCid":{}},{"NonVerifiedDealSpace":"0","VerifiedInfos":[{"Client":3061409,"AllocationId":61240089,"Data":{"/":"baga6ea4seaqbuieim7slc3wu7kms436xpnorao5jxr6tqftnqsysfxcp5dnduia"},"Size":34359738368}],"UnsealedCid":{}},{"NonVerifiedDealSpace":"0","VerifiedInfos":[{"Client":3061409,"AllocationId":61454935,"Data":{"/":"baga6ea4seaqfodzysx243k4s6ieuxzzoawew4ckycynubcd5t67vxctunfjt6pq"},"Size":34359738368}],"UnsealedCid":{}}]}}`,
+			height:   3857557,
+		},
+		{
+			name:     "NV22 - failed activation",
+			txType:   parser.MethodActivateDeals,
+			txFrom:   txFrom,
+			txTo:     txTo,
+			metadata: `{"MethodNum":"6","Params":{"Sectors":[{"SectorNumber":37656,"SectorType":8,"SectorExpiry":4920235,"DealIDs":[78950968]},{"SectorNumber":37888,"SectorType":8,"SectorExpiry":4920235,"DealIDs":[78951195]},{"SectorNumber":37549,"SectorType":8,"SectorExpiry":4920235,"DealIDs":[79166044]}],"ComputeCID":false},"Return":{"ActivationResults":{"SuccessCount":2,"FailCodes":[{"Idx":1,"Code":16}]},"Activations":[{"NonVerifiedDealSpace":"0","VerifiedInfos":[{"Client":3061409,"AllocationId":61239862,"Data":{"/":"baga6ea4seaqgvrjfj65lawcocwvrpgq7h53oghvto6akrys6wllhbbckchfgefy"},"Size":34359738368}],"UnsealedCid":{}},{"NonVerifiedDealSpace":"0","VerifiedInfos":[{"Client":3061409,"AllocationId":61240089,"Data":{"/":"baga6ea4seaqbuieim7slc3wu7kms436xpnorao5jxr6tqftnqsysfxcp5dnduia"},"Size":34359738368}],"UnsealedCid":{}},{"NonVerifiedDealSpace":"0","VerifiedInfos":[{"Client":3061409,"AllocationId":61454935,"Data":{"/":"baga6ea4seaqfodzysx243k4s6ieuxzzoawew4ckycynubcd5t67vxctunfjt6pq"},"Size":34359738368}],"UnsealedCid":{}}]}}`,
+			height:   3857557,
+		},
+	}
+
+	for _, test := range tests {
+		t.Run(test.name, func(t *testing.T) {
+			_, err := eg.GenerateDealsEvents(context.Background(), []*types.Transaction{
+				{
+					TxBasicBlockData: types.TxBasicBlockData{
+						BasicBlockData: types.BasicBlockData{
+							Height: test.height,
+						},
+					},
+					TxCid:         txCid,
+					TxType:        test.txType,
+					TxFrom:        test.txFrom,
+					TxTo:          test.txTo,
+					TxMetadata:    test.metadata,
+					Status:        tools.GetExitCodeStatus(exitcode.Ok),
+					SubcallStatus: tools.GetExitCodeStatus(exitcode.Ok),
+				},
+			}, tipsetCid, filTypes.EmptyTSK)
+			require.NoError(t, err)
+		})
+	}
+}