Skip to content

Commit bae8b56

Browse files
authored
Fix cacheSetsMetric (#119)
* Fix cacheSetsMetric * test
1 parent 442f07c commit bae8b56

File tree

2 files changed

+4
-2
lines changed

2 files changed

+4
-2
lines changed

pkg/zrouter/zmiddlewares/cache.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -116,7 +116,7 @@ func cacheResponseIfNeeded(rw *responseWriter, r *http.Request, cache zcache.ZCa
116116
return
117117
}
118118

119-
if err := metricServer.IncrementMetric(cacheSetsMetric, GetRoutePattern(r)); err != nil {
119+
if err := metricServer.IncrementMetric(cacheSetsMetric, GetSubRoutePattern(r), GetRoutePattern(r)); err != nil {
120120
logger.GetLoggerFromContext(r.Context()).Errorf("Error incrementing cache_sets metric: %v", err)
121121
}
122122
}

pkg/zrouter/zmiddlewares/zcache_test.go

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,9 @@ func TestCacheMiddleware(t *testing.T) {
2727
"/cached-path": 5 * time.Minute,
2828
}}
2929

30-
r.Use(CacheMiddleware(metrics.NewTaskMetrics("", "", "appName"), mockCache, cacheConfig))
30+
ms := metrics.NewTaskMetrics("", "", "appName")
31+
RegisterRequestMetrics(ms)
32+
r.Use(CacheMiddleware(ms, mockCache, cacheConfig))
3133

3234
// Simulate a response that should be cached
3335
r.Get("/cached-path", func(w http.ResponseWriter, r *http.Request) {

0 commit comments

Comments
 (0)