Incorrect number of written bytes

jleni · jleni · commit 2684efe91edc · 2019-01-29T13:59:07.000+01:00
diff --git a/hid_enabled.go b/hid_enabled.go
@@ -188,6 +188,13 @@ func (dev *Device) Write(b []byte) (int, error) {
 		failure, _ := wcharTToString(message)
 		return 0, errors.New("hidapi: " + failure)
 	}
+
+	if runtime.GOOS == "windows" {
+		// Do not consider the prepended byte when returning number of written bytes
+		// otherwise this can lead to confusion in other layers
+		written -= 1
+	}
+
 	return written, nil
 }
 

Original file line number	Diff line number	Diff line change
`@@ -188,6 +188,13 @@ func (dev *Device) Write(b []byte) (int, error) {`
`188`	`188`	`failure, _ := wcharTToString(message)`
`189`	`189`	`return 0, errors.New("hidapi: " + failure)`
`190`	`190`	`}`
	`191`	`+`
	`192`	`+ if runtime.GOOS == "windows" {`
	`193`	`+ // Do not consider the prepended byte when returning number of written bytes`
	`194`	`+ // otherwise this can lead to confusion in other layers`
	`195`	`+ written -= 1`
	`196`	`+ }`
	`197`	`+`
`191`	`198`	`return written, nil`
`192`	`199`	`}`
`193`	`200`