Skip to content

Commit 4882c3b

Browse files
authored
Fix EIP test (#42)
* fix eip test * update deps * update CI * remove duplicate code * format files
1 parent d333804 commit 4882c3b

File tree

4 files changed

+62
-69
lines changed

4 files changed

+62
-69
lines changed

.github/workflows/rust_audit.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ jobs:
1010
security_audit:
1111
runs-on: ubuntu-latest
1212
steps:
13-
- uses: actions/checkout@v4
13+
- uses: actions/checkout@v5
1414
with:
1515
submodules: true
1616

.github/workflows/rust_periodic_audit.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ jobs:
99
security_audit:
1010
runs-on: ubuntu-latest
1111
steps:
12-
- uses: actions/checkout@v4
12+
- uses: actions/checkout@v5
1313
with:
1414
submodules: true
1515

Cargo.lock

Lines changed: 44 additions & 53 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

tests/integration_test.rs

Lines changed: 16 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -43,6 +43,20 @@ fn app() -> FilecoinApp<TransportNativeHID> {
4343
FilecoinApp::new(TransportNativeHID::new(&HIDAPI).expect("unable to create transport"))
4444
}
4545

46+
/// Helper function to prepare a personal message with Filecoin prefix
47+
/// This constructs the message format: "\x19Filecoin Signed Message:\n<length><message>"
48+
fn prepare_personal_message_with_prefix(personal_message: &[u8]) -> Vec<u8> {
49+
let prefix = b"\x19Filecoin Signed Message:\n";
50+
let length_string = personal_message.len().to_string();
51+
52+
let mut message_with_prefix = Vec::new();
53+
message_with_prefix.extend_from_slice(prefix);
54+
message_with_prefix.extend_from_slice(length_string.as_bytes());
55+
message_with_prefix.extend_from_slice(personal_message);
56+
57+
message_with_prefix
58+
}
59+
4660
#[tokio::test]
4761
#[serial]
4862
async fn version() {
@@ -281,13 +295,7 @@ async fn sign_personal_msg() {
281295
.await
282296
.unwrap();
283297

284-
let prefix = b"\x19Filecoin Signed Message:\n";
285-
let length_bytes = (personal_message.len() as u32).to_be_bytes();
286-
287-
let mut message_with_prefix = Vec::new();
288-
message_with_prefix.extend_from_slice(prefix);
289-
message_with_prefix.extend_from_slice(&length_bytes);
290-
message_with_prefix.extend_from_slice(personal_message);
298+
let message_with_prefix = prepare_personal_message_with_prefix(personal_message);
291299

292300
let mut reconstructed_sig_bytes = [0u8; 64];
293301
reconstructed_sig_bytes[0..32].copy_from_slice(&signature.r);
@@ -338,13 +346,7 @@ async fn sign_personal_msg_long_message() {
338346
.await
339347
.unwrap();
340348

341-
let prefix = b"\x19Filecoin Signed Message:\n";
342-
let length_bytes = (personal_message.len() as u32).to_be_bytes();
343-
344-
let mut message_with_prefix = Vec::new();
345-
message_with_prefix.extend_from_slice(prefix);
346-
message_with_prefix.extend_from_slice(&length_bytes);
347-
message_with_prefix.extend_from_slice(&personal_message);
349+
let message_with_prefix = prepare_personal_message_with_prefix(&personal_message);
348350

349351
let mut reconstructed_sig_bytes = [0u8; 64];
350352
reconstructed_sig_bytes[0..32].copy_from_slice(&signature.r);

0 commit comments

Comments
 (0)