token formatting and neuron txs for visibility and voting power (#264)

* Add token information registry and helper functions

* Add formatting function to be use for registry look-up

* Add commands to retrieve token registry

* Add support to JS package to retrieve token registry from ledger devices

* Add zemu test to retrieve device's token registry

* Fix lookup function and remove comments

* Proper check to decide if using tokenInfo from table or default to Tokens marker for amount and fee

* Fix warnings

* Apply the rigth format to Fees

* Remove formatting of amounts and use ICP token by default for SNS transactions

* fix(decimals): Fix current test by removing formattig on unknown tokens

* Fix fee formatting for known and unknown tokens

* Use token formatting according to token table for sns transactions

* Update neuron tests

* Fix for split neuron amount being read wrong

* Update tests

* Remove unused variable

* Fix warnings

* Bump version and update snapshots

* Add token decimal tests

* Fix token display title and update test vector(fixed)

* Remove logging code

* Remove unused variable

* Add support for neuron voting power updates

* Fix parser and complet UI for voting power transaction

* feat(manageneuron): Add neuron refresh voting power test in zemu

* shore: fix warnings and unused arguments

* Add support to handle the configuration operation to set neuron visibility

* Add zemu test to check neuron visibility transaction

* Update app/src/candid/nns_parser.c

Co-authored-by: Andrés Benso <[email protected]>

* Update app/src/candid/nns_parser.c

Co-authored-by: Andrés Benso <[email protected]>

* Remove unnecessary comments

* Reduce title length to Max fee + token name

* Remove testing snapshot

* Fix fee title and update tests

* Update snapshots to reproduce a change from Maximun fee to Max fee

* Remove commented code which is not used

* Update snapshots

---------

Co-authored-by: Andrés Benso <[email protected]>

Author: neithanmo

CMakeLists.txt

@@ -124,6 +124,7 @@ file(GLOB_RECURSE LIB_SRC
         ${CMAKE_CURRENT_SOURCE_DIR}/app/src/base32.c
         ${CMAKE_CURRENT_SOURCE_DIR}/app/src/protobuf/*.c
         ${CMAKE_CURRENT_SOURCE_DIR}/app/src/parser_print_*.c
+        ${CMAKE_CURRENT_SOURCE_DIR}/app/src/token_info.c
         )
 
 add_library(app_lib STATIC

app/Makefile.version

@@ -3,4 +3,4 @@ APPVERSION_M=3
 # This is the minor version of this release
 APPVERSION_N=2
 # This is the patch version of this release
-APPVERSION_P=4
+APPVERSION_P=5

app/src/apdu_handler.c

@@ -30,6 +30,7 @@
 #include "crypto.h"
 #include "handlers/path.h"
 #include "handlers/process_chunks.h"
+#include "handlers/tokens.h"
 #include "parser_impl.h"
 #include "tx.h"
 #include "view.h"
@@ -195,6 +196,18 @@ void handleApdu(volatile uint32_t *flags, volatile uint32_t *tx, uint32_t rx) {
       }
 #endif
 
+      case INS_SUPPORTED_TOKENS_LEN: {
+        CHECK_PIN_VALIDATED()
+        handleGetNumOfTokens(flags, tx, rx);
+        break;
+      }
+
+      case INS_TOKEN_AT_IDX: {
+        CHECK_PIN_VALIDATED()
+        handleGetTokenIdx(flags, tx, rx);
+        break;
+      }
+
       default:
         THROW(APDU_CODE_INS_NOT_SUPPORTED);
       }

app/src/candid/candid_parser.c

@@ -140,6 +140,7 @@ parser_error_t readCandidListNeurons(parser_tx_t *tx, const uint8_t *input, uint
 }
 
 parser_error_t readCandidManageNeuron(parser_tx_t *tx, const uint8_t *input, uint16_t inputSize) {
+    zemu_log("readCandidManageNeuron\n");
     // Create context and auxiliary ctx
     CREATE_CTX(ctx, tx, input, inputSize)
     candid_transaction_t txn;
@@ -151,7 +152,6 @@ parser_error_t readCandidManageNeuron(parser_tx_t *tx, const uint8_t *input, uin
 
     CHECK_PARSER_ERR(readAndCheckRootType(&ctx))
 
-
     CHECK_PARSER_ERR(getCandidTypeFromTable(&txn, tx->candid_rootType))
 
     CHECK_PARSER_ERR(readCandidRecordLength(&txn))
@@ -164,7 +164,7 @@ parser_error_t readCandidManageNeuron(parser_tx_t *tx, const uint8_t *input, uin
             return readNNSManageNeuron(&ctx, &txn);
 
         default:
-            ZEMU_LOGF(100, "Error: transaction type not supported\n")
+            zemu_log("Error: transaction type not supported\n");
     }
 
     return parser_unexpected_value;