Build intallers on PR (#288)

* Build intallers on PR

* fixes

* bump version

* Add dev branch to CI

Author: 0xPxt

.github/workflows/main.yml

@@ -6,6 +6,7 @@ on:
     branches:
       - main
       - develop
+      - dev
 
 jobs:
   configure:
@@ -220,7 +221,6 @@ jobs:
 
   build_package_nanos:
     needs: [configure, setup_rust, build, build_ledger, test_zemu]
-    if: ${{ github.ref == 'refs/heads/main' }}
     runs-on: ubuntu-latest
     container:
       image: zondax/ledger-app-builder:latest
@@ -264,10 +264,11 @@ jobs:
         id: nanos
         run: echo "tag_name=$(./app/pkg/installer_nanos.sh version)" >> $GITHUB_OUTPUT
       - name: Create or Update Release (1)
+        if: ${{ github.ref == 'refs/heads/main' }}
         id: create_release_0
         uses: softprops/action-gh-release@v1
         env:
-          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} # This token is provided by Actions, you do not need to create your own token
+          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
         with:
           files: ./app/pkg/installer_nanos.sh
           tag_name: ${{ steps.nanos.outputs.tag_name }}
@@ -284,7 +285,6 @@ jobs:
         test_zemu,
         rust_tests,
       ]
-    if: ${{ github.ref == 'refs/heads/main' }}
     runs-on: ubuntu-latest
     container:
       image: zondax/ledger-app-builder:latest
@@ -328,10 +328,11 @@ jobs:
         id: nanosp
         run: echo "tag_name=$(./app/pkg/installer_nanos_plus.sh version)" >> $GITHUB_OUTPUT
       - name: Update Release
+        if: ${{ github.ref == 'refs/heads/main' }}
         id: update_release_2
         uses: softprops/action-gh-release@v1
         env:
-          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} # This token is provided by Actions, you do not need to create your own token
+          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
         with:
           files: ./app/pkg/installer_nanos_plus.sh
           tag_name: ${{ steps.nanosp.outputs.tag_name }}
@@ -348,7 +349,6 @@ jobs:
         test_zemu,
         rust_tests,
       ]
-    if: ${{ github.ref == 'refs/heads/main' }}
     runs-on: ubuntu-latest
     container:
       image: zondax/ledger-app-builder:latest
@@ -383,7 +383,6 @@ jobs:
             ${{ runner.os }}-rust-
       - name: Install rust-src component
         run: rustup component add rust-src --toolchain stable-x86_64-unknown-linux-gnu
-
       - name: Build Stax
         shell: bash -l {0}
         run: |
@@ -392,10 +391,11 @@ jobs:
         id: stax
         run: echo "tag_name=$(./app/pkg/installer_stax.sh version)" >> $GITHUB_OUTPUT
       - name: Update Release
+        if: ${{ github.ref == 'refs/heads/main' }}
         id: update_release_2
         uses: softprops/action-gh-release@v1
         env:
-          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} # This token is provided by Actions, you do not need to create your own token
+          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
         with:
           files: ./app/pkg/installer_stax.sh
           tag_name: ${{ steps.stax.outputs.tag_name }}
@@ -412,7 +412,6 @@ jobs:
         test_zemu,
         rust_tests,
       ]
-    if: ${{ github.ref == 'refs/heads/main' }}
     runs-on: ubuntu-latest
     container:
       image: zondax/ledger-app-builder:latest
@@ -447,7 +446,6 @@ jobs:
             ${{ runner.os }}-rust-
       - name: Install rust-src component
         run: rustup component add rust-src --toolchain stable-x86_64-unknown-linux-gnu
-
       - name: Build Flex
         shell: bash -l {0}
         run: |
@@ -456,10 +454,11 @@ jobs:
         id: flex
         run: echo "tag_name=$(./app/pkg/installer_flex.sh version)" >> $GITHUB_OUTPUT
       - name: Update Release
+        if: ${{ github.ref == 'refs/heads/main' }}
         id: update_release_2
         uses: softprops/action-gh-release@v1
         env:
-          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} # This token is provided by Actions, you do not need to create your own token
+          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
         with:
           files: ./app/pkg/installer_flex.sh
           tag_name: ${{ steps.flex.outputs.tag_name }}

app/Makefile.version

@@ -3,4 +3,4 @@ APPVERSION_M=4
 # This is the minor version of this release
 APPVERSION_N=0
 # This is the patch version of this release
-APPVERSION_P=3
+APPVERSION_P=4

app/rust/src/lib.rs

@@ -2,7 +2,6 @@
 #![no_builtins]
 #![macro_use]
 #![allow(dead_code)]
-#![deny(unused_crate_dependencies)]
 // We used different config flags names
 // in order to not possibly colide with other
 // defined in dependencies

app/rust/src/parser/consent_message/msg.rs

@@ -212,7 +212,7 @@ impl<'a> FromCandidHeader<'a> for ConsentMessage<'a> {
                 let total_size = fields_start.len() - current.len();
 
                 // Take only the fields content from the correct position
-                let (rem, fields) = take(total_size)(fields_start)?;
+                let (_rem, fields) = take(total_size)(fields_start)?;
 
                 // Continue parsing from where we left off
                 let rem = current;