Merge pull request #21 from Zondax/dev

New Release

Author: emmanuelm41

src/index.ts

@@ -38,21 +38,26 @@ import {
 } from './types'
 
 export * from './types'
+export * from '@zondax/ledger-js/dist/responseError'
 
 const DUMMY_PATH = "m/44'/1338'/0"
+const DKG_APP_CLA = 0x63
+const REGULAR_APP_CLA = 0x59
 
 export default class IronfishApp extends GenericApp {
   readonly INS!: IronfishIns
   constructor(transport: Transport, dkgMode?: boolean) {
     if (transport == null) throw new Error('Transport has not been defined')
 
     const params: ConstructorParams = {
-      cla: dkgMode ? 0x63 : 0x59,
+      cla: dkgMode ? DKG_APP_CLA : REGULAR_APP_CLA,
       ins: {
+        // Common instructions
         GET_VERSION: 0x00,
+        // Regulars app instructions
         GET_KEYS: 0x01,
         SIGN: 0x02,
-        //DKG Instructions
+        // DKG app instructions
         DKG_IDENTITY: 0x10,
         DKG_ROUND_1: 0x11,
         DKG_ROUND_2: 0x12,

src/serialize.ts

@@ -1,6 +1,5 @@
 export const serializeDkgRound1 = (index: number, identities: string[], minSigners: number): Buffer => {
   let blob = Buffer.alloc(1 + 1 + identities.length * 129 + 1)
-  console.log(`dkgRound1 msg size: ${blob.byteLength}`)
 
   blob.writeUint8(index)
   blob.writeUint8(identities.length, 1)
@@ -17,7 +16,6 @@ export const serializeDkgRound2 = (index: number, round1PublicPackages: string[]
   let round1SecretPackageLen = round1SecretPackage.length / 2
 
   let blob = Buffer.alloc(1 + 1 + 2 + round1PublicPackages.length * round1PublicPackagesLen + 2 + round1SecretPackageLen)
-  console.log(`dkgRound2 msg size: ${blob.byteLength}`)
 
   let pos = 0
 
@@ -73,7 +71,6 @@ export const serializeDkgRound3Min = (
       2 +
       gskBytes.length * gskLen
   )
-  console.log(`dkgRound3 msg size: ${blob.byteLength}`)
 
   let pos = 0
 
@@ -146,7 +143,6 @@ export const serializeDkgRound3Min = (
 
 export const serializeDkgGetCommitments = (tx_hash: string): Buffer => {
   let blob = Buffer.alloc(32)
-  console.log(`dkgGetCommitment msg size: ${blob.byteLength}`)
 
   blob.fill(Buffer.from(tx_hash, 'hex'), 0)
 
@@ -159,7 +155,6 @@ export const serializeDkgSign = (pkRandomness: string, frostSigningPackage: stri
   let txHashLen = 32
 
   let blob = Buffer.alloc(2 + pkRandomnessLen + 2 + frostSigningPackageLen + txHashLen)
-  console.log(`dkgSign msg size: ${blob.byteLength}`)
 
   let pos = 0