Always return custom ResponseError in sendGenericChunk

Author: 0xPxt

package.json

@@ -52,9 +52,10 @@
     "eslint-plugin-promise": "^7.1.0",
     "eslint-plugin-tsdoc": "^0.3.0",
     "eslint-plugin-unused-imports": "^4.0.0",
+    "jest": "^30.0.5",
     "prettier": "^3.3.2",
     "sort-package-json": "^2.10.1",
-    "ts-jest": "^29.1.4",
+    "ts-jest": "^29.4.0",
     "ts-node": "^10.9.2",
     "typescript": "^5.4.5"
   },

src/app.ts

@@ -126,10 +126,19 @@ export default class BaseApp {
 
     const statusList = [LedgerError.NoErrors, LedgerError.DataIsInvalid, LedgerError.BadKeyHandle]
 
-    const responseBuffer = await this.transport.send(this.CLA, ins, payloadType, p2, chunk, statusList)
-    const response = processResponse(responseBuffer, this.CUSTOM_APP_ERROR_DESCRIPTION)
+    let responseBuffer
 
-    return response
+    try {
+      responseBuffer = await this.transport.send(this.CLA, ins, payloadType, p2, chunk, statusList)
+    } catch (e) {
+      // In case transport.send send throws an Error, we still want our custom ResponseError
+      let statusCode: number = (e as any).statusCode || (e as any).returnCode
+      const buffer = Buffer.alloc(2)
+      buffer.writeUInt16BE(statusCode, 0)
+      return processResponse(buffer, this.CUSTOM_APP_ERROR_DESCRIPTION)
+    }
+
+    return processResponse(responseBuffer, this.CUSTOM_APP_ERROR_DESCRIPTION)
   }
 
   /**