Remove signed_message from returned value (#8)

Author: 0xPxt

README.md

@@ -25,7 +25,7 @@ We recommend using the npmjs package in order to receive updates/fixes.
 | Operation       | Response                                                                         | Command                                                                                                         | Notes                                       |
 | --------------- | -------------------------------------------------------------------------------- | --------------------------------------------------------------------------------------------------------------- | ------------------------------------------- |
 | signTransaction | { signature: string }                                                            | txType + senderAccount + senderAddress + receiverAddress + amount + fee + nonce + validUntil + memo + networkId | Signs a Mina transaction                    |
-| signMessage     | { field: string, scalar: string, raw_signature: string, signed_message: string } | account + networkId + message                                                                                   | Signs a message using the specified account |
+| signMessage     | { field: string, scalar: string, raw_signature: string } | account + networkId + message                                                                                   | Signs a message using the specified account |
 
 ### Transaction Types
 

src/app.ts

@@ -63,7 +63,6 @@ interface SignMessageResponse extends BaseLedgerResponse {
   field: string | null;
   scalar: string | null;
   raw_signature?: string | null;
-  signed_message?: string | null;
 }
 
 export class MinaApp extends BaseApp {
@@ -306,7 +305,6 @@ export class MinaApp extends BaseApp {
         field: null,
         scalar: null,
         raw_signature: null,
-        signed_message: null,
         returnCode: "-6",
         message: "Message is empty",
       };
@@ -316,7 +314,6 @@ export class MinaApp extends BaseApp {
         field: null,
         scalar: null,
         raw_signature: null,
-        signed_message: null,
         returnCode: "-7",
         message: "Message too long",
       };
@@ -350,37 +347,15 @@ export class MinaApp extends BaseApp {
 
       const response = processResponse(responseBuffer);
 
-      // Validate minimum buffer length (64 bytes for signature + 1 byte for message length)
-      if (response.length() < 65) {
-        throw new Error("Response buffer too short");
-      }
-
-      // First read the signature (64 bytes)
       const signature = response.readBytes(64).toString("hex");
       const sigLength = signature.length;
       const field_extracted = signature.substring(0, sigLength / 2);
       const scalar_extracted = signature.substring(sigLength / 2, sigLength);
 
-      // Then read the message length (1 byte)
-      const messageLength = response.readBytes(1).readUInt8();
-
-      // Validate remaining buffer length against message length
-      if (response.length() < messageLength) {
-        throw new Error(
-          `Response buffer too short for message: expected ${messageLength} bytes but only ${response.length()} remaining`,
-        );
-      }
-
-      // Finally read the message
-      const returnedMessage = response
-        .readBytes(messageLength)
-        .toString("utf8");
-
       return {
         field: BigInt("0x" + field_extracted).toString(),
         scalar: BigInt("0x" + scalar_extracted).toString(),
         raw_signature: signature,
-        signed_message: returnedMessage,
         returnCode: "9000",
       };
     } catch (e) {
@@ -389,7 +364,6 @@ export class MinaApp extends BaseApp {
         field: null,
         scalar: null,
         raw_signature: null,
-        signed_message: null,
         returnCode: respError.returnCode.toString(),
         message: respError.errorMessage,
       };