Sign prefix (and don't display prefix on screen) (#33)

* Sign prefix without displaying it

* Bump Version

* Snapshots

* Add toml dependency to requirements.txt

* ragger tests snapshots

* return message through apdu buffer

Author: 0xPxt

Makefile

@@ -31,7 +31,7 @@ GIT_DESCRIBE=$(shell git describe --tags --abbrev=8 --always --long --dirty 2>/d
 VERSION_TAG=$(shell echo $(GIT_DESCRIBE) | sed 's/^v//g')
 APPVERSION_M=1
 APPVERSION_N=4
-APPVERSION_P=4
+APPVERSION_P=5
 APPVERSION=$(APPVERSION_M).$(APPVERSION_N).$(APPVERSION_P)
 APPNAME = "Mina"
 

src/sign_msg.c

@@ -49,6 +49,19 @@ void sign_message(uint8_t *dataBuffer, uint8_t dataLength)
     uint8_t bits[TX_BITSTRINGS_BYTES];
     ROInput   roinput = roinput_create(input_fields, bits);
 
+    // Add PREFIX to the buffer
+    const uint8_t prefix_len = strlen(PREFIX);
+    uint8_t prefixed_buffer[5 + TX_BITSTRINGS_BYTES];
+    
+    if (dataLength + prefix_len > sizeof(prefixed_buffer)) {
+        THROW(INVALID_PARAMETER);
+    }
+    
+    memcpy(prefixed_buffer, PREFIX, prefix_len);
+    memcpy(prefixed_buffer + prefix_len, dataBuffer, dataLength);
+    dataLength += prefix_len;
+    dataBuffer = prefixed_buffer;
+
     if ((dataLength < ACCOUNT_LENGTH + NETWORK_LENGTH) || (dataLength > 5 + TX_BITSTRINGS_BYTES)) {
         THROW(INVALID_PARAMETER);
     }
@@ -85,5 +98,7 @@ void sign_message(uint8_t *dataBuffer, uint8_t dataLength)
 
     memmove(G_io_apdu_buffer, &sig, sizeof(sig));
 
-    sendResponse(sizeof(sig), true);
+    G_io_apdu_buffer[sizeof(sig)] = dataLength;
+    memmove(G_io_apdu_buffer + sizeof(sig) + 1, dataBuffer, dataLength);
+    sendResponse(sizeof(sig) + 1 + dataLength, true);
 }

src/sign_msg.h

@@ -8,6 +8,8 @@
 #define NETWORK_OFFSET 4
 #define MSG_OFFSET 5
 
+#define PREFIX "Message : "
+
 void handle_sign_msg(uint8_t p1, uint8_t p2, uint8_t *dataBuffer,
                     uint8_t dataLength, volatile unsigned int *flags);
 

tests/requirements.txt

@@ -2,3 +2,4 @@ base58
 bip32
 ragger[tests,speculos]==1.32.1
 ledgerblue
+toml