Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make it work in strict mode #43

Open
1 task
sibelius opened this issue Nov 7, 2019 · 3 comments · May be fixed by #44
Open
1 task

make it work in strict mode #43

sibelius opened this issue Nov 7, 2019 · 3 comments · May be fixed by #44
Labels
accepted work_in_progress

Comments

@sibelius
Copy link

sibelius commented Nov 7, 2019

https://reactjs.org/docs/strict-mode.html

  • it should not use the old react context

My recommendation is to avoid classes and move to functions and hooks
@Vitao18
Copy link

Vitao18 commented Nov 7, 2019

Hey
Can I help on this issue?

@sibelius
Copy link
Author

sibelius commented Nov 7, 2019

send pull request

@Vitao18 Vitao18 linked a pull request Nov 9, 2019 that will close this issue
Open
@a-x-
Copy link
Owner

a-x- commented Nov 23, 2019

Hey, you're awesome, guys! Thanks for you job.

I reviewed all the changed files, but still not tried to run it.

We'll released alpha version after PR be merged, so we be able to check new it on our projects

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
accepted work_in_progress
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Refactor/class to func component Vitao18/react-easy-print
3 participants
@sibelius @a-x- @Vitao18