Skip to content

Commit 029f005

Browse files
committed
don't replace false keys
1 parent 9cac7f0 commit 029f005

File tree

2 files changed

+5
-3
lines changed

2 files changed

+5
-3
lines changed

Diff for: src/_filter/collection/group-by.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ angular.module('a8m.group-by', [ 'a8m.filter-watcher' ])
1717
getParse = $parse(property),
1818
get = function(el) {
1919
var val = getParse(el);
20-
if(nullReplacement !== undefined && !val){
20+
if(nullReplacement !== undefined && (val == null || val == undefined)){
2121
return nullReplacement;
2222
}
2323
return val;

Diff for: test/spec/filter/collection/group-by.js

+4-2
Original file line numberDiff line numberDiff line change
@@ -83,14 +83,16 @@ describe('groupByFilter', function() {
8383
{name: 'Paula', team: 'beta'},
8484
{name: 'Scruath', team: 'gamma'},
8585
{name: 'Alex', team: null },
86-
{name: 'Rob' }
86+
{name: 'Rob' },
87+
{name: 'Sven', team: false }
8788
];
8889

8990
expect(filter(players, 'team', 'a')).toEqual( {
9091
a: [players[5], players[6]],
9192
alpha: [players[0]],
9293
beta: [players[1], players[3]],
93-
gamma: [players[2], players[4]]
94+
gamma: [players[2], players[4]],
95+
'false': [players[7]]
9496
});
9597

9698
});

0 commit comments

Comments
 (0)