devonfw#63: Improvements after review

cli/pom.xml

@@ -116,7 +116,7 @@
               <goal>copy-resources</goal>
             </goals>
             <configuration>
-              <outputDirectory>${basedir}/target/package</outputDirectory>
+              <outputDirectory>${project.build.directory}/package</outputDirectory>
               <resources>          
                 <resource>
                   <directory>src/main/package</directory>

cli/src/main/assembly/exec.xml

@@ -25,7 +25,7 @@
     </fileSet>
     <fileSet>
       <directory>${project.build.directory}/package</directory>
-      <outputDirectory>./target/package</outputDirectory>
+      <outputDirectory>.</outputDirectory>
     </fileSet>
   </fileSets>
 </assembly>

cli/src/main/java/com/devonfw/tools/ide/commandlet/EnvironmentCommandlet.java

@@ -37,7 +37,7 @@ public String getName() {
   @Override
   public boolean isIdeHomeRequired() {
 
-    return false;
+    return true;
   }
 
   @Override

cli/src/main/package/bin/ide

@@ -0,0 +1,25 @@
+#!/usr/bin/env bash
+
+# Check if arguments are given
+if [ -n "${1}" ]; then
+  # Call native ideasy.exe with user-provided arguments
+  ideasy "$@"
+
+  rc=$?
+  if [ "${rc}" != 0 ]; then
+    exit ${rc}
+  fi
+fi
+
+envariable=
+if [ "${OSTYPE}" = "cygwin" ] || [ "${OSTYPE}" = "msys" ] ; then
+	envariable="ideasy env --bash"
+else
+  envariable="ideasy env"
+fi
+
+rc=$?
+
+if [ $rc = 0 ]; then
+  eval "$envariable"
+fi