Rewrite to support Gnome 45 #13
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AFAIU this version number is intended to be filled with a linear version number by extensions.gnome.org, so any version in here is not preserved when uploading to there. Also, for gnome-shell, it seems that the presence of this version number is an indication that the extension installation is managed by gnome-shell. In practice, when using a symlink directly into the git checkout for this extension, the presence of this version key causes gnome-shell to (presumably) consider this extension invalid and (observed) replace it with the latest version downloaded from extensions.gnome.org.
It is probably also supported by intermediate versions, but I have not tested that.
In gnome 45, the module system is significantly different, so the code structure is changed significantly. This changes the code to this new structure, without making any functional changes. This change also removes support for older versions of Gnome. This fixes aXe1#12.
Open
Open
No changes are needed. This was tested on 47 and assumes it also works on 46.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In gnome 45, the module system is significantly different, so the code
structure is changed significantly. This changes the code to this new
structure, without making any functional changes.
This change also removes support for older versions of Gnome.
This fixes #12.
I created this PR on top of #8, which is not merged yet, but keeping that history is probably a good idea.