Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Google Sheet for data, script to update data files from that #58

Merged
merged 1 commit into from
Jul 9, 2022

Conversation

abesto
Copy link
Owner

@abesto abesto commented Jun 19, 2022

I've spent some time creating a new Google Sheet that contains only and exactly the data used by this app, and some tooling to update the data in the app with one command. This should hopefully

  • provide a bit of extra transparency, maybe enable collaboration (the sheet is publicly readable, but of course not writable)
  • make it easier to work with the data
    • I added a few additional pieces of data verification right to the spreadsheet
    • The Tracks sheet in particular should be much nicer to work with now - thanks to the Data Verification feature of Google Docs, we now have checkboxes there
    • it's now completely clear what pieces are used by the app; namely: exactly what's in this new sheet
  • eliminate human error in the Google Sheet -> app import step

@rsr427 I'd appreciate your eyes on, and thoughts about

I've published a preview version of the app using these new changes to https://d4sk2ytizwr62.cloudfront.net/ (same caveats as before: going directly to https://d4sk2ytizwr62.cloudfront.net/career won't work, but clicking through the menu from https://d4sk2ytizwr62.cloudfront.net/ will).

@abesto abesto requested a review from rsr427 June 19, 2022 15:19
@rsr427
Copy link
Collaborator

rsr427 commented Jun 30, 2022 via email

@rsr427
Copy link
Collaborator

rsr427 commented Jul 5, 2022

Files look clean. I updated the Track matrix with the new tracks both in this file and the old file. The old file could tell me how many classes would race at that track, which is helpful. It was copy and paste otherwise.

I used a video from RD to get the configuration names since I don't have AMS2 with me currently. I thought there were supposed to be multiple Cordoba configurations, but apparently we have one for now. I will update as more are released.

@abesto
Copy link
Owner Author

abesto commented Jul 5, 2022

Lovely, thank you!

The old file could tell me how many classes would race at that track, which is helpful.

If that's good enough for you, a new tab in the new sheet would be a safe way to do this - another tab won't confuse the automation.

Update, later: I've added a new sheet called [#(Car Classes) / Track] with this.

I updated the Track matrix with the new tracks both in this file and the old file.

Nice, I'll pull those in, time to see the automation in action! :D

I used a video from RD to get the configuration names since I don't have AMS2 with me currently.

Hah, I'll double-check then just in case.

@abesto
Copy link
Owner Author

abesto commented Jul 5, 2022

Differences I see between the sheet and the sim:

  • Buenos Aires has a "No.6 S" layout that's currently missing from the sheet. Shall I add it in, with the same classes as the No.6 layout? (or leave it to you)
  • The Buenos Aires layouts in-game don't seem to have the human-friendly names in parentheses, like (Modern). Shall we drop them to avoid confusion? Or keep them in for extra information? Where do they even come from?
  • The circuit name for Buenos Aires seems to be "Buenos Aires Circuito". I'd probably opt for using that full name.
    • Note that the default "Group By Location" in-game actually groups by location / city. Most of the time the city is a prefix of the name of the circuit, but not always. For example under Granja Viana we have both "Copa Sao Paulo Kart Stage 2" (note the complete lack of "Granja Viana" in the track name) and Granja Viana Kart 101. Unfortunately this means the current Track / Configuration setup we have is basically broken; my best idea is to transition to a Location / Configuration setup. By "broken" I mean that from "Copa Sao Paulo Kart Stage 2" there's no way in the game to find out that it's hidden under "Granja Viana". A problem for another day - just filed Track / Configuration model doesn't map well to the game UI #59 for this.
  • Cordoba does have additional layouts: No.2 and No.4. Shall I add them with the same classes as the TC layout? (or leave it to you)
  • Córdoba in-game has an accent on the first "o". By default I'd say let's include it (the app should be just fine, in theory, but I'll test). Do you actively think we should leave accents out instead? (Same for Termas de Río Hondo)

@rsr427
Copy link
Collaborator

rsr427 commented Jul 5, 2022 via email

@abesto
Copy link
Owner Author

abesto commented Jul 6, 2022

Buenos Aires No.6 S [...] If the layout difference is a chicane, it could probably be the same.

Yep, it's a chicane. Added to the sheet with the same classes as No.6!

Buenos Aires track / layout names: alright, I've just removed the human-friendly names in parentheses to match the game, and added the full name. While I was at it, I dropped the space between "No." and the number to completely match the in-game name (so "No.6", instead of "No. 6").

This goes back to my National vs International layout ideology. I would honestly want to study what the layouts are used for. My bet is that the main layout is probably equivalent to the type of track that the Brazil Stock car series races in. For the smaller layouts, probably like the tracks I picked for the Club racing series. Does that make sense? But I can come back with a definitive answer.

Yep, makes perfect sense! No.2 is a short layout, No.4 is the same as TC, just has ~2 extra turns (longer than a chicane). Would love if you could add these, make sure the classes make sense / are consistent with the other stuff we have.

Dude, I don't know how to do the accents. But yes, I think that should be the case.

Lol, ok :D My secret trick is plopping the name of the track into Google / Wikipedia, then copy-pasting from there :P Gave this a bit of thought, turns out it's a bit more involved than I initially thought: #60. For the moment, let's not add accents; I'll tackle this separately.

Sorry I can't highlight my responses neatly, I can't figure it out on this mail app...

Heh, no worries, it's pretty clear as is. FWIW, I'd expect emails to support Markdown as well, but have never actually tested this (so a quote would be: start the line with a > character)

@rsr427
Copy link
Collaborator

rsr427 commented Jul 6, 2022 via email

@abesto abesto merged commit e248aa7 into master Jul 9, 2022
@abesto abesto deleted the data-sheet branch July 9, 2022 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants