Merge pull request #1047 from ably/release/1.2.45

Release/1.2.45

Author: sacOO7

CHANGELOG.md

@@ -1,5 +1,18 @@
 # Change Log
 
+## [1.2.45](https://github.com/ably/ably-java/tree/v1.2.45)
+
+[Full Changelog](https://github.com/ably/ably-java/compare/v1.2.44...v1.2.45)
+
+**Closed issues:**
+
+- [RTL5] Incomplete spec implementation for channel DETACH/ATTACH [\#1045](https://github.com/ably/ably-java/issues/1045)
+- [RTL7h] Throw exception for optional callback [\#1040](https://github.com/ably/ably-java/issues/1040)
+
+**Merged pull requests:**
+
+- [ECO-5117] Fix channel ATTACH/DETACH state checks [\#1046](https://github.com/ably/ably-java/pull/1046) ([sacOO7](https://github.com/sacOO7))
+
 ## [1.2.44](https://github.com/ably/ably-java/tree/v1.2.44)
 
 [Full Changelog](https://github.com/ably/ably-java/compare/v1.2.43...v1.2.44)

CONTRIBUTING.md

@@ -219,7 +219,7 @@ You may wish to make changes to Ably Java or Ably Android, and test it immediate
 - Open the directory printed from the output of that command. Inside that folder, get the `ably-android-x.y.z.aar`, and place it your Android project's `libs/` directory. Create this directory if it doesn't exist.
 - Add an `implementation` dependency on the `.aar`:
 ```groovy
-implementation files('libs/ably-android-1.2.44.aar')
+implementation files('libs/ably-android-1.2.45.aar')
 ```
 - Add the `implementation` (not `testImplementation`) dependencies found in `dependencies.gradle` to your project. This is because the `.aar` does not contain dependencies.
 - Build/run your application.

README.md

@@ -20,13 +20,13 @@ Include the library by adding an `implementation` reference to `dependencies` bl
 For [Java](https://mvnrepository.com/artifact/io.ably/ably-java/latest):
 
 ```groovy
-implementation 'io.ably:ably-java:1.2.44'
+implementation 'io.ably:ably-java:1.2.45'
 ```
 
 For [Android](https://mvnrepository.com/artifact/io.ably/ably-android/latest):
 
 ```groovy
-implementation 'io.ably:ably-android:1.2.44'
+implementation 'io.ably:ably-android:1.2.45'
 ```
 
 The library is hosted on [Maven Central](https://mvnrepository.com/repos/central), so you need to ensure that the repository is referenced also; IDEs will typically include this by default:
@@ -512,7 +512,7 @@ Add the following dependency to your `build.gradle` file:
 
 ```groovy
 dependencies {
-    runtimeOnly("io.ably:network-client-okhttp:1.2.44")
+    runtimeOnly("io.ably:network-client-okhttp:1.2.45")
 }
 ```
 

gradle.properties

@@ -1,5 +1,5 @@
 GROUP=io.ably
-VERSION_NAME=1.2.44
+VERSION_NAME=1.2.45
 
 POM_INCEPTION_YEAR=2015
 POM_URL=https://github.com/ably/ably-java

lib/src/test/java/io/ably/lib/test/realtime/RealtimeHttpHeaderTest.java

@@ -88,7 +88,7 @@ public void realtime_websocket_param_test() {
              * Defaults.ABLY_AGENT_PARAM, as ultimately the request param has been derived from those values.
              */
             assertEquals("Verify correct lib version", requestParameters.get("agent"),
-                    Collections.singletonList("ably-java/1.2.44 jre/" + System.getProperty("java.version")));
+                    Collections.singletonList("ably-java/1.2.45 jre/" + System.getProperty("java.version")));
 
             /* Spec RTN2a */
             assertEquals("Verify correct format", requestParameters.get("format"),