lispy.el: no need to "xv" twice to move test overlay

* lispy-inline.el (lispy--show): Set `last-point' property of
  `lispy-overlay'.

* lispy.el (lispy-view-test): Works only from "|(should (string=".
When the point has moved from the last invocation, just move the overlay
and update it appropriately instead of just hiding it.

Author: abo-abo

lispy-inline.el

@@ -227,7 +227,8 @@ Return t if at least one was deleted."
 
 (defun lispy--show (str)
   "Show STR hint when `lispy--show-fits-p' is t."
-  (let ((strs (lispy--show-fits-p str)))
+  (let ((last-point (point))
+        (strs (lispy--show-fits-p str)))
     (when strs
       (setq str (lispy--join-pad
                  strs
@@ -249,7 +250,8 @@ Return t if at least one was deleted."
           (setq lispy-overlay (make-overlay (point) (+ (point) 1)))
           (overlay-put lispy-overlay 'priority 9999))
         (overlay-put lispy-overlay 'display str)
-        (overlay-put lispy-overlay 'after-string ""))
+        (overlay-put lispy-overlay 'after-string "")
+        (put 'lispy-overlay 'last-point last-point))
       t)))
 
 (defun lispy--pretty-args (symbol)

lispy.el

@@ -3245,17 +3245,16 @@ If the region is active, replace instead of yanking."
 (defun lispy-view-test ()
   "View better the test at point."
   (interactive)
-  (cond ((overlayp lispy-overlay)
+  (cond ((and (overlayp lispy-overlay)
+              (eq (point) (get 'lispy-overlay 'last-point)))
          (delete-overlay lispy-overlay)
          (setq lispy-overlay nil))
 
-        ((or (looking-at "(string=")
-             (looking-at "(should"))
+
+
+        ((looking-at "(should (string=")
          (setq lispy-hint-pos (point))
-         (let* ((expr (read (lispy--string-dwim)))
-                (expr (if (eq (car expr) 'should)
-                          (cadr expr)
-                        expr))
+         (let* ((expr (cadr (read (lispy--string-dwim))))
                 (str1 (cadr (cadr expr)))
                 (str2 (caddr expr))
                 (keys (cddadr expr))
@@ -3269,7 +3268,7 @@ If the region is active, replace instead of yanking."
                     (propertize str2 'face 'lispy-face-hint)))))
 
         (t
-         (user-error "Should position point before (string="))))
+         (lispy-complain "should position point before (should (string="))))
 
 ;;* Predicates
 (defun lispy--in-string-p ()