Skip to content

Check that we handle correctly the Windows PE versions #3790

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
pombredanne opened this issue May 29, 2024 · 1 comment · May be fixed by #4116
Open

Check that we handle correctly the Windows PE versions #3790

pombredanne opened this issue May 29, 2024 · 1 comment · May be fixed by #4116

Comments

@pombredanne
Copy link
Member

We collect binary metadata in DLLs.

See https://github.com/nexB/scancode-toolkit/blob/4f49985c26b6b8f951f116dfa3fe39ce27bd4ce8/src/packagedcode/win_pe.py#L110

But see this publication:
https://learn.microsoft.com/en-us/troubleshoot/developer/dotnet/framework/general/assembly-version-assembly-file-version

We may also wrongly use "Assembly Version" instead of "AssemblyVersion"
@alok1304
Copy link
Contributor

@pombredanne I checked it, basically, what i do, is I use AssemblyVersion instead of Assembly Version.
I got AssemblyVersion is null for tests\packagedcode\data\win_pe\Microsoft.Practices.EnterpriseLibrary.Caching.dll and
tests\packagedcode\data\win_pe\Moq.Silverlight.dll

But in previous it is pointing to
"Assembly Version": "2.0.0.0", for tests\packagedcode\data\win_pe\Microsoft.Practices.EnterpriseLibrary.Caching.dll
and
"Assembly Version": "4.2.1507.118", for tests\packagedcode\data\win_pe\Moq.Silverlight.dll.

I think there might be some issue I raise a PR soon regarding this.

alok1304 added a commit to alok1304/scancode-toolkit that referenced this issue Jan 23, 2025
@alok1304
change Assembly Version to AssemblyVersion
9cc045f 
Reference: aboutcode-org#3790
@alok1304 alok1304 linked a pull request Jan 23, 2025 that will close this issue
Open
6 tasks
alok1304 added a commit to alok1304/scancode-toolkit that referenced this issue Jan 23, 2025
@alok1304
change Assembly Version to AssemblyVersion
51c9005 
Reference: aboutcode-org#3790
Signed-off-by: Alok Kumar <[email protected]>
alok1304 added a commit to alok1304/scancode-toolkit that referenced this issue Mar 30, 2025
@alok1304
change Assembly Version to AssemblyVersion
18d3b59 
Reference: aboutcode-org#3790
Signed-off-by: Alok Kumar <[email protected]>
alok1304 added a commit to alok1304/scancode-toolkit that referenced this issue Mar 30, 2025
@alok1304
use both AssemblyVersion and Assembly Version
9caa6b3 
Reference: aboutcode-org#3790
Signed-off-by: Alok Kumar <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Change Assembly Version to AssemblyVersion in win_pe alok1304/scancode-toolkit
2 participants
@pombredanne @alok1304