Add tests

Signed-off-by: Tushar Goel <[email protected]>

Author: TG1999

vulnerabilities/pipelines/fill_vulnerability_summary_pipeline.py

@@ -58,7 +58,8 @@ def fill_missing_summaries(self):
 
             if matching_advisories.exists():
                 # Take the first matching advisory with a summary
-                best_advisory = matching_advisories.first()
+                # get the advisory that was collected the most recently
+                best_advisory = matching_advisories.order_by("-date_collected").first()
                 vulnerability.summary = best_advisory.summary
                 vulnerability.save()
                 self.log(

vulnerabilities/tests/pipelines/test_fill_vulnerability_summary_pipeline.py

@@ -118,3 +118,36 @@ def test_non_nvd_advisory_ignored(self):
         # Check that the vulnerability still has no summary
         vulnerability.refresh_from_db()
         self.assertEqual(vulnerability.summary, "")
+
+    def test_multiple_matching_advisories(self):
+        """
+        Test that the most recent matching advisory is used when there are multiple.
+        """
+        vulnerability = Vulnerability.objects.create(
+            vulnerability_id="VCID-1234",
+            summary="",
+        )
+        alias = Alias.objects.create(alias="CVE-2024-1234", vulnerability=vulnerability)
+
+        # Create two NVD advisories with the same alias
+        Advisory.objects.create(
+            summary="First matching advisory",
+            created_by="nvd_importer",
+            date_collected=datetime.datetime(2024, 1, 1, tzinfo=pytz.UTC),
+            aliases=["CVE-2024-1234"],
+        )
+
+        Advisory.objects.create(
+            summary="Second matching advisory",
+            created_by="nvd_importer",
+            date_collected=datetime.datetime(2024, 1, 2, tzinfo=pytz.UTC),
+            aliases=["CVE-2024-1234"],
+        )
+
+        # Run the pipeline
+        pipeline = FillVulnerabilitySummariesPipeline()
+        pipeline.fill_missing_summaries()
+
+        # Check that the vulnerability now has the most recent summary
+        vulnerability.refresh_from_db()
+        self.assertEqual(vulnerability.summary, "Second matching advisory")