Skip to content

Commit 1368b90

Browse files
committedJun 29, 2017
Merge remote-tracking branch 'upstream/master'
* upstream/master: (55 commits) Fix minor typo (facebook#2679) Bootstrap with Yarn when available (facebook#2673) Add more info about apache client side routing (facebook#2666) Test Node 8 on Travis (facebook#2659) Add json and css to lint-staged in template README (facebook#2671) Add a note about fixed vulnerability in 1.0.8 Publish Changelog for 1.0.8 (facebook#2664) Reformat source code with Prettier 1.5.2 Update Prettier to v1 (facebook#2465) Update ISSUE_TEMPLATE.md Local testing docker links (facebook#2662) Better React Native Web support (facebook#2511) Bump dependencies (facebook#2658) Minor code style edits to user guide (facebook#2660) Don't ask to install webpack for using Styleguidist (facebook#2656) Put react-scripts in dependencies, not devDependencies (facebook#2657) Razzle added to the alternatives (facebook#2517) Warn about large bundle sizes (facebook#2648) Add instructions to use source-map-explorer (facebook#1641) ... # Conflicts: # packages/react-dev-utils/package.json # packages/react-scripts/config/webpack.config.dev.js # packages/react-scripts/config/webpack.config.prod.js # packages/react-scripts/package.json
2 parents 6eb3066 + 7b5a589 commit 1368b90

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

74 files changed

+1590
-509
lines changed
 

‎.github/ISSUE_TEMPLATE.md

+131-30
Original file line numberDiff line numberDiff line change
@@ -1,59 +1,160 @@
1-
If you are reporting a bug, please fill in below. Otherwise feel free to remove this template entirely.
1+
<!--
2+
PLEASE READ THE FIRST SECTION :-)
3+
-->
24

3-
### Can you reproduce the problem with latest npm?
5+
### Is this a bug report?
46

5-
Many errors, especially related to "missing modules", are due to npm bugs.
7+
(write your answer here)
68

7-
If you're using Windows, [follow these instructions to update npm](https://github.com/npm/npm/wiki/Troubleshooting#upgrading-on-windows).
9+
<!--
10+
If you answered "Yes":
11+
12+
Please note that your issue will be fixed much faster if you spend about
13+
half an hour preparing it, including the exact reproduction steps and a demo.
14+
15+
If you're in a hurry or don't feel confident, it's fine to report bugs with
16+
less details, but this makes it less likely they'll get fixed soon.
817
9-
If you're using OS X or Linux, run this to update npm:
18+
In either case, please fill as many fields below as you can.
1019
11-
```
12-
npm install -g npm@latest
20+
If you answered "No":
1321
14-
cd your_project_directory
15-
rm -rf node_modules
16-
npm install
17-
```
22+
If this is a question or a discussion, you may delete this template and write in a free form.
23+
Note that we don't provide help for webpack questions after ejecting.
24+
You can find webpack docs at https://webpack.js.org/.
25+
-->
1826

19-
Then try to reproduce the issue again.
2027

21-
Can you still reproduce it?
28+
### Can you also reproduce the problem with npm 4.x?
2229

23-
### Description
30+
<!--
31+
Many errors, especially related to "missing modules", are due to npm bugs.
32+
Which version of npm are you running? You can find out by checking:
2433
25-
What are you reporting?
34+
npm -v
2635
27-
### Expected behavior
36+
If it is 5.x, please be aware that it has more than 50 known bugs, and
37+
is not guaranteed to work with Create React App.
2838
29-
Tell us what you think should happen.
39+
If it's not starting with 4, try to install npm 4.x:
3040
31-
### Actual behavior
41+
npm install -g npm@4
42+
cd your_project_directory
43+
rm -rf node_modules
44+
npm cache clear
45+
npm install
46+
47+
Then try to reproduce the issue again.
48+
Can you still reproduce it?
49+
50+
Note: Please try this even if you are using Yarn so that we know whether it's a Yarn-only bug.
51+
-->
52+
53+
(Write your answer here.)
54+
55+
56+
### Which terms did you search for in User Guide?
57+
58+
<!--
59+
There are a few common documented problems, such as watcher not detecting changes, or build failing.
60+
They are described in the Troubleshooting section of the User Guide:
61+
62+
https://github.com/facebookincubator/create-react-app/blob/master/packages/react-scripts/template/README.md#troubleshooting
63+
64+
Please scan these few sections for common problems.
65+
Additionally, you can search the User Guide itself for something you're having issues with:
66+
67+
https://github.com/facebookincubator/create-react-app/blob/master/packages/react-scripts/template/README.me
68+
69+
If you didn't find the solution, please share which words you searched for.
70+
This helps us improve documentation for future readers who might encounter the same problem.
71+
-->
72+
73+
(Write your answer here if relevant.)
3274

33-
Tell us what actually happens.
3475

3576
### Environment
3677

37-
Run these commands in the project folder and fill in their results:
78+
<!--
79+
Please fill in all the relevant fields by running these commands in terminal.
80+
-->
3881

39-
1. `npm ls react-scripts` (if you haven’t ejected):
40-
2. `node -v`:
41-
3. `npm -v`:
82+
1. `node -v`:
83+
2. `npm -v`:
84+
4. `yarn --version` (if you use Yarn):
85+
3. `npm ls react-scripts` (if you haven’t ejected):
4286

4387
Then, specify:
4488

4589
1. Operating system:
46-
2. Browser and version:
90+
2. Browser and version (if relevant):
91+
92+
93+
### Steps to Reproduce
94+
95+
<!--
96+
How would you describe your issue to someone who doesn’t know you or your project?
97+
Try to write a sequence of steps that anybody can repeat to see the issue.
98+
-->
99+
100+
(Write your steps here:)
101+
102+
1.
103+
2.
104+
3.
105+
106+
107+
### Expected Behavior
108+
109+
<!--
110+
How did you expect the tool to behave?
111+
It’s fine if you’re not sure your understanding is correct.
112+
Just write down what you thought would happen.
113+
-->
114+
115+
(Write what you thought would happen.)
116+
117+
118+
### Actual Behavior
119+
120+
<!--
121+
Did something go wrong?
122+
Is something broken, or not behaving as you expected?
123+
Please attach screenshots if possible! They are extremely helpful for diagnosing issues.
124+
-->
125+
126+
(Write what happened. Please add screenshots!)
127+
47128

48129
### Reproducible Demo
49130

50-
Please take the time to create a new app that reproduces the issue.
131+
<!--
132+
If you can, please share a project that reproduces the issue.
133+
This is the single most effective way to get an issue fixed soon.
134+
135+
There are two ways to do it:
136+
137+
* Create a new app and try to reproduce the issue in it.
138+
This is useful if you roughly know where the problem is, or can’t share the real code.
139+
140+
* Or, copy your app and remove things until you’re left with the minimal reproducible demo.
141+
This is useful for finding the root cause. You may then optionally create a new project.
51142
52-
Alternatively, you could copy your app that experiences the problem and start removing things until you’re left with the minimal reproducible demo.
143+
This is a good guide to creating bug demos: https://stackoverflow.com/help/mcve
144+
Once you’re done, push the project to GitHub and paste the link to it below:
145+
-->
53146

54-
(Accidentally, you might get to the root of your problem during that process.)
147+
(Paste the link to an example project and exact instructions to reproduce the issue.)
55148

56-
Push to GitHub and paste the link here.
149+
<!--
150+
What happens if you skip this step?
151+
152+
We will try to help you, but in many cases it is impossible because crucial
153+
information is missing. In that case we'll tag an issue as having a low priority,
154+
and eventually close it if there is no clear direction.
155+
156+
We still appreciate the report though, as eventually somebody else might
157+
create a reproducible example for it.
57158
58-
By doing this, you're helping the Create React App contributors a big time!
59-
Demonstrable issues gets fixed faster.
159+
Thanks for helping us help you!
160+
-->

‎.github/PULL_REQUEST_TEMPLATE.md

+1-2
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,7 @@
11
<!--
22
Thank you for sending the PR!
3-
If you changed any code, there are just two more things to do:
43
5-
* Provide us with clear instructions on how you verified your changes work. Bonus points for screenshots!
4+
If you changed any code, please provide us with clear instructions on how you verified your changes work. Bonus points for screenshots!
65
76
Happy contributing!
87
-->

0 commit comments

Comments
 (0)
Please sign in to comment.