Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature] Add recording parameters validation #126

Open
jeffersoncasimir opened this issue Jun 5, 2024 · 3 comments
Open

[feature] Add recording parameters validation #126

jeffersoncasimir opened this issue Jun 5, 2024 · 3 comments
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers queue

Comments

@jeffersoncasimir
Copy link
Collaborator

jeffersoncasimir commented Jun 5, 2024

It would be valuable to validate the content of the recording parameters json by cross-referencing the validity of some fields.

@jeffersoncasimir jeffersoncasimir added queue enhancement New feature or request good first issue Good for newcomers labels Jun 5, 2024
@christinerogers christinerogers changed the title [feature] Add EEG metadata validation [feature] Add EEG.json preview / metadata validation Jun 5, 2024
@christinerogers christinerogers changed the title [feature] Add EEG.json preview / metadata validation [feature] Add _EEG.json preview / metadata validation Jun 5, 2024
@christinerogers
Copy link
Collaborator

@jefferson to add a new issue documenting what the channel count issues is when using mne_bids -- in contrast to the montage standard

But the Wizard should nuke the channel count - shouldn't be an issue.
Good to confirm it won't be an issue.

@christinerogers
Copy link
Collaborator

recording parameters file is sometimes empty.

@jeffersoncasimir jeffersoncasimir changed the title [feature] Add _EEG.json preview / metadata validation [feature] Add recording parameters LORIS validation Jun 14, 2024
@jeffersoncasimir jeffersoncasimir changed the title [feature] Add recording parameters LORIS validation [feature] Add recording parameters validation Jun 14, 2024
@christinerogers
Copy link
Collaborator

christinerogers commented Sep 13, 2024

There are cases when the count was generated from a standard montage and doesn't reflect the actual channel count.
is this not done by the bids-validator ?

@jeffersoncasimir @laemtl - assigned to clarify and followup by Sept. 17

@jeffersoncasimir to give data example

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers queue
Projects
None yet
Development

No branches or pull requests

3 participants