Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename all code that refers to 'Singularity' as 'Apptainer' #1362

Open
prioux opened this issue Nov 20, 2023 · 1 comment · May be fixed by #1366
Open

Rename all code that refers to 'Singularity' as 'Apptainer' #1362

prioux opened this issue Nov 20, 2023 · 1 comment · May be fixed by #1366
Assignees
@MontrealSergiy
Labels
Admin Features or bugs related to administrative features Documentation User Interface

Comments

@prioux
Copy link
Member

prioux commented Nov 20, 2023

We've got a bunch of code that refers to singularity. We should just rename everything (variables, info text etc) to Apptainer. Also the default command to invoke internally should switch to 'apptainer'.

Most of this is purely esthetic.

The only thing we should keep is the Userfile model 'SingularityFile'.
@prioux prioux added User Interface Documentation Admin Features or bugs related to administrative features labels Nov 20, 2023
@MontrealSergiy
Copy link
Contributor

MontrealSergiy commented Nov 24, 2023 •
edited
Loading

Should model fields/db columns remain same, for instance, should we keep ToolConfig.singularity_overlays_specs or rename into ToolConfig.apptainer_overlays_specs ?
also singularity_use_short_workdir, singularity_executable_name

@MontrealSergiy MontrealSergiy linked a pull request Dec 18, 2023 that will close this issue
Open
@MontrealSergiy MontrealSergiy self-assigned this Dec 18, 2023
@MontrealSergiy MontrealSergiy linked a pull request Dec 18, 2023 that will close this issue
refactoring: replacing singularity with apptainer in variable names #1366
Open
@MontrealSergiy MontrealSergiy removed a link to a pull request Dec 18, 2023
refactoring: replacing singularity with apptainer in variable names #1366
Open
@MontrealSergiy MontrealSergiy linked a pull request Dec 18, 2023 that will close this issue
refactoring: replacing singularity with apptainer in variable names #1366
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MontrealSergiy MontrealSergiy

Labels
Admin Features or bugs related to administrative features Documentation User Interface
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactoring: replacing singularity with apptainer in variable names MontrealSergiy/cbrain
2 participants
@prioux @MontrealSergiy