fix IAM, add tests

Author: devksingh4

cloudformation/iam.yml

@@ -62,6 +62,7 @@ Resources:
               Effect: Allow
               Resource:
                 - !Sub arn:aws:dynamodb:${AWS::Region}:${AWS::AccountId}:table/infra-events-api-records/*
+                - !Sub arn:aws:dynamodb:${AWS::Region}:${AWS::AccountId}:table/infra-events-api-records
         PolicyName: lambda-dynamo
 Outputs:
   MainFunctionRoleArn:

src/routes/events.ts

@@ -92,14 +92,11 @@ const eventsPlugin: FastifyPluginAsync = async (fastify, _options) => {
         await dynamoClient.send(
           new PutItemCommand({
             TableName: genericConfig.DynamoTableName,
-            Item: marshall(
-              {
-                ...request.body,
-                id: entryUUID,
-                createdBy: request.username,
-              },
-              { removeUndefinedValues: true },
-            ),
+            Item: marshall({
+              ...request.body,
+              id: entryUUID,
+              createdBy: request.username,
+            }),
           }),
         );
         reply.send({

tests/live/ical.test.ts

@@ -0,0 +1,28 @@
+import { expect, test } from "vitest";
+import { InternalServerError } from "../../src/errors/index.js";
+import { EventsGetResponse } from "../../src/routes/events.js";
+import { describe } from "node:test";
+import { OrganizationList } from "../../src/orgs.js";
+
+const appKey = process.env.APPLICATION_KEY;
+if (!appKey) {
+  throw new InternalServerError({ message: "No application key found" });
+}
+
+const baseEndpoint = `https://${appKey}.aws.qa.acmuiuc.org`;
+test("getting all events", async () => {
+  const response = await fetch(`${baseEndpoint}/api/v1/ical`);
+  expect(response.status).toBe(200);
+});
+
+describe("Getting specific calendars", async () => {
+  for (const org of OrganizationList) {
+    test(`Get ${org} calendar`, async () => {
+      const response = await fetch(`${baseEndpoint}/api/v1/ical/${org}`);
+      expect(response.status).toBe(200);
+      expect(response.headers.get("Content-Disposition")).toEqual(
+        'attachment; filename="calendar.ics"',
+      );
+    });
+  }
+});