Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Passing vend commands via json or args #7

Open
narendasan opened this issue Mar 23, 2017 · 9 comments
Open

Passing vend commands via json or args #7

narendasan opened this issue Mar 23, 2017 · 9 comments

Comments

@narendasan
Copy link
Member

Discussion to have on direction would like input from @sameetandpotatoes and @abrandemuehl

@rauhul
Copy link
Member

rauhul commented Mar 23, 2017

@narendasan did we decide on running a RESTful server on the Pi? Eric mentioned Illinois net could cause issues.

@narendasan
Copy link
Member Author

Regardless of what we decide we do need to run a web server due to our network architecture. We can get the pi cleared for the network or we could use the network switch to address those issues

@abrandemuehl
Copy link
Contributor

Can we run a "Merch" service wherever the rest of the Groot services run, then keep a persistent connection to that service from the Pi?

@narendasan
Copy link
Member Author

I think eric was worried about connecting to the network. As to architecture, I think the idea of ipad hits groot with hits the pi is ok and a webserver on a pi is probably the easiest way to handle the pi part

@wchill
Copy link
Member

wchill commented Mar 23, 2017

If the Pi is not directly connected to a wall jack, then you will run into issues with NAT since the Pi will not be reachable outside of whatever network it is connected to.

The best way to do this is have the Groot service wait for the Pi to connect to it (using regular TCP sockets, WebSockets, or perhaps using a reverse SSH tunnel and running the webserver on the forwarded port, up to you) and then pass commands over that connection. This will get around the NAT issue.

@narendasan
Copy link
Member Author

narendasan commented Mar 23, 2017 via email

@narendasan
Copy link
Member Author

narendasan commented Mar 23, 2017 via email

@rauhul
Copy link
Member

rauhul commented Apr 2, 2017

We should move to passing the vending commands via json so we can support vend queues

abrandemuehl added a commit that referenced this issue Apr 3, 2017
Makes a change in the API to allow for multiple locations to be passed

Resolves #7
@abrandemuehl
Copy link
Contributor

I put a PR that makes the JSON args an array under the key 'items'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants