strings: Rename strings.h to avoid clashing with /usr/include/strings.h

This was detected with:

  In file included from /home/acme/git/pahole/strings.h:9,
                   from /usr/include/string.h:432,
                   from /home/acme/git/pahole/lib/bpf/src/libbpf_common.h:12,
                   from /home/acme/git/pahole/lib/bpf/src/libbpf.h:20,
                   from /home/acme/git/pahole/lib/bpf/src/ringbuf.c:20:
  /home/acme/git/pahole/lib/bpf/src/btf.h:33:11: error: expected ‘;’ before ‘void’
     33 | LIBBPF_API void btf__free(struct btf *btf);
        |           ^~~~~
        |           ;

libbpf_common.h has:

  #include <string.h>

  #ifndef LIBBPF_API
  #define LIBBPF_API __attribute__((visibility("default")))
  #endif

So before defining LIBBPF_API it includes libc's string.h that in turn
includes pahole's strings.h and now it includes:

  #include "lib/bpf/src/btf.h"

That will need the LIBBPF_API, b00m.

So lets just rename pahole's strings.h to pahole_strings.h to avoid this
pitfall.

This patch was moved to before this problem takes place so that we keep
everything bisectable.

Cc: Andrii Nakryiko <[email protected]>
Signed-off-by: Arnaldo Carvalho de Melo <[email protected]>

Author: acmel

Diff for: CMakeLists.txt

@@ -149,7 +149,7 @@ install(TARGETS codiff ctracer dtagnames pahole pdwtags
 install(TARGETS dwarves LIBRARY DESTINATION ${LIB_INSTALL_DIR})
 install(TARGETS dwarves dwarves_emit dwarves_reorganize LIBRARY DESTINATION ${LIB_INSTALL_DIR})
 install(FILES dwarves.h dwarves_emit.h dwarves_reorganize.h
-	      dutil.h gobuffer.h list.h rbtree.h strings.h
+	      dutil.h gobuffer.h list.h rbtree.h pahole_strings.h
 	      btf_encoder.h config.h ctf_encoder.h ctf.h
 	      elfcreator.h elf_symtab.h hash.h libbtf.h libctf.h
 	DESTINATION ${CMAKE_INSTALL_PREFIX}/include/dwarves/)

Diff for: MANIFEST

@@ -42,7 +42,7 @@ rbtree.h
 scncopy.c
 syscse.c
 strings.c
-strings.h
+pahole_strings.h
 dutil.c
 dutil.h
 changes-v1.13

Diff for: dwarf_loader.c

@@ -23,7 +23,7 @@
 #include "list.h"
 #include "dwarves.h"
 #include "dutil.h"
-#include "strings.h"
+#include "pahole_strings.h"
 #include "hash.h"
 
 struct strings *strings;

Diff for: dwarves.c

@@ -27,7 +27,7 @@
 #include "list.h"
 #include "dwarves.h"
 #include "dutil.h"
-#include "strings.h"
+#include "pahole_strings.h"
 #include <obstack.h>
 
 #define obstack_chunk_alloc malloc

Diff for: dwarves.h

@@ -18,7 +18,7 @@
 #include "dutil.h"
 #include "list.h"
 #include "rbtree.h"
-#include "strings.h"
+#include "pahole_strings.h"
 
 struct cu;
 

Diff for: strings.h renamed to pahole_strings.h

@@ -4,7 +4,7 @@
   Copyright (C) 2008 Arnaldo Carvalho de Melo <[email protected]>
 */
 
-#include "strings.h"
+#include "pahole_strings.h"
 #include "gobuffer.h"
 
 #include <search.h>