Skip to content

Commit 472c3c4

Browse files
committed
Set group as default when number of rows is above 1000. Hide labels if series is abouve 10 on piecharts
1 parent f04e433 commit 472c3c4

File tree

7 files changed

+10
-121
lines changed

7 files changed

+10
-121
lines changed

bower.json

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,6 +30,7 @@
3030
"lodash": "*",
3131
"recline.backend.gdocs": "https://github.com/okfn/recline.backend.gdocs.git#e81bb237759353932834a38a0ec810441e0ada10",
3232
"csv.js": "https://github.com/okfn/csv.js.git#976b61384a1808eb464aca5876e5ea46c98deaee",
33-
"recline.view.nvd3.js": "https://github.com/NuCivic/recline.view.nvd3.js.git#removing_steps"
33+
"recline.view.nvd3.js": "https://github.com/NuCivic/recline.view.nvd3.js.git#removing_steps",
34+
"recline":"[email protected]:okfn/recline.git#2b7095794e6273b45b7761534d74b59e839d3c1f"
3435
}
3536
}

examples/index.html

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@
3535
<script src="../vendor/slickgrid/plugins/slick.rowselectionmodel.js"></script>
3636
<script src="../vendor/slickgrid/plugins/slick.rowmovemanager.js"></script>
3737
<script src="../vendor/moment/moment.js"></script>
38-
<script src="http://okfnlabs.org/recline/dist/recline.js"></script>
38+
<script src="../vendor/recline/dist/recline.min.js"></script>
3939
<script src="../vendor/d3/d3.js"></script>
4040
<script src="../vendor/nvd3/build/nv.d3.js"></script>
4141
</head>
@@ -49,11 +49,10 @@
4949
</div>
5050
</div>
5151
</div>
52-
52+
<footer> <!-- Disclamer here --></footer>
5353
<script type="text/javascript" src="../vendor/recline.view.nvd3.js/dist/recline.view.nvd3.min.js"></script>
54+
<script type="text/javascript" src="../vendor/recline.view.nvd3.js/dist/recline.view.nvd3.controls.min.js"></script>
5455
<script type="text/javascript" src="../src/recline.URLState.js"></script>
55-
<script type="text/javascript" src="../src/recline.view.nvd3.baseControl.js"></script>
56-
<script type="text/javascript" src="../src/controls.js"></script>
5756
<script type="text/javascript" src="../src/recline.view.nvd3.embedControl.js"></script>
5857
<script type="text/javascript" src="../src/MultiStageView.js"></script>
5958
<script type="text/javascript" src="../src/LoadDataView.js"></script>

examples/view.html

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -44,6 +44,7 @@
4444
<body>
4545
<div id="chart"></div>
4646
<script type="text/javascript" src="../vendor/recline.view.nvd3.js/dist/recline.view.nvd3.min.js"></script>
47+
<script type="text/javascript" src="../vendor/recline.view.nvd3.js/dist/recline.view.nvd3.controls.min.js"></script>
4748
<script type="text/javascript" src="../src/recline.URLState.js"></script>
4849
</body>
4950

examples/view.js

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,8 +13,9 @@
1313
state.set('height', window.innerHeight - 20);
1414

1515
var model = new recline.Model.Dataset(state.get('model'));
16+
model.queryState.attributes.size = 10000000;
1617
model.fetch().done(function(){
17-
var chart = new recline.View.nvd3[state.get('graphType')]({
18+
window.chart = new recline.View.nvd3[state.get('graphType')]({
1819
model: model,
1920
state: state,
2021
el: $('#chart'),

src/ChartOptionsView.js

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -57,6 +57,7 @@
5757
var self = this;
5858
var graphType = self.state.get('graphType');
5959

60+
self.state.set('group', true, {silent:true});
6061
self.$el.html(Mustache.render(self.template, self.state.toJSON()));
6162

6263
// Common controls for all the charts.

src/LoadDataView.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,7 @@
4040
};
4141
state.set('model', new recline.Model.Dataset(source));
4242
state.set('source', source);
43-
state.get('model').queryState.attributes.size = 10000;
43+
state.get('model').queryState.attributes.size = 10000000;
4444
state.get('model').fetch().done(function(data){
4545
cb(state);
4646
});

src/controls.js

Lines changed: 0 additions & 114 deletions
This file was deleted.

0 commit comments

Comments
 (0)