File tree 4 files changed +31
-3
lines changed 4 files changed +31
-3
lines changed Original file line number Diff line number Diff line change @@ -24,9 +24,18 @@ echo "$TRAVIS_NODE_VERSION"
24
24
yarn --version
25
25
26
26
# Disable Xdebug except on code coverage jobs.
27
- if [[ ! " $ORCA_COVERAGE_ENABLE " ]]; then
27
+ if [[ ! " $ORCA_COVERAGE_ENABLE " == TRUE ]]; then
28
28
if [[ " $TRAVIS " ]]; then phpenv config-rm xdebug.ini; fi
29
- if [[ " $GITHUB_ACTIONS " ]]; then sudo phpdismod -v ALL xdebug; fi
29
+ if [[ " $GITHUB_ACTIONS " ]]; then
30
+ # phpdismod would be simpler but flaky
31
+ # @see https://github.com/shivammathur/setup-php/issues/350#issuecomment-735370872
32
+ scan_dir=$( php --ini | grep additional | sed -e " s|.*: s*||" )
33
+ ini_file=$( php --ini | grep " Loaded Configuration" | sed -e " s|.*:s*||" | sed " s/ //g" )
34
+ pecl_file=" $scan_dir " /99-pecl.ini
35
+ sudo sed -Ei " /xdebug/d" " ${ini_file:? } "
36
+ sudo sed -Ei " /xdebug/d" " ${pecl_file:? } "
37
+ sudo rm -rf " $scan_dir " /* xdebug*
38
+ fi
30
39
fi
31
40
32
41
# Travis CI installs YAML from PECL, but it's already present in GitHub Actions.
Original file line number Diff line number Diff line change @@ -13,6 +13,17 @@ cd "$(dirname "$0")" || exit 1; source ../_includes.sh
13
13
14
14
cd ../../../ || exit 1
15
15
16
+ XDEBUG_IS_ENABLED=$( php -r ' echo function_exists("xdebug_get_code_coverage") ? "TRUE" : "FALSE";' )
17
+
18
+ if [[ " $ORCA_COVERAGE_ENABLE " == TRUE && " $XDEBUG_IS_ENABLED " == " FALSE" ]]; then
19
+ echo " ORCA_COVERAGE_ENABLE is on but Xdebug is disabled"
20
+ exit 1
21
+ fi
22
+
23
+ if [[ " $ORCA_COVERAGE_ENABLE " == FALSE && " $XDEBUG_IS_ENABLED " == " TRUE" ]]; then
24
+ echo " ORCA_COVERAGE_ENABLE is off but Xdebug is enabled"
25
+ exit 1
26
+ fi
16
27
17
28
if [[ " $ORCA_JOB " == " STATIC_CODE_ANALYSIS" ]]; then
18
29
./vendor/bin/phpcs
Original file line number Diff line number Diff line change 1
- v3.10.0
1
+ v3.10.1
Original file line number Diff line number Diff line change 1
1
# Changelog
2
2
3
+ ## [ v3.10.1] ( https://github.com/acquia/orca/tree/v3.10.1 ) (2021-10-01)
4
+
5
+ [ Full Changelog] ( https://github.com/acquia/orca/compare/v3.10.0...v3.10.1 )
6
+
7
+ ** Fixed bugs:**
8
+
9
+ - Xdebug never disabled on Travis CI [ \# 159] ( https://github.com/acquia/orca/pull/159 ) ([ danepowell] ( https://github.com/danepowell ) )
10
+
3
11
## [ v3.10.0] ( https://github.com/acquia/orca/tree/v3.10.0 ) (2021-09-29)
4
12
5
13
[ Full Changelog] ( https://github.com/acquia/orca/compare/v3.9.0...v3.10.0 )
You can’t perform that action at this time.
0 commit comments