Skip to content

Commit 3dba39f

Browse files
committed
Merge branch 'release/3.10.1'
2 parents 72f8759 + 9c58655 commit 3dba39f

File tree

4 files changed

+31
-3
lines changed

4 files changed

+31
-3
lines changed

bin/ci/before_install.sh

Lines changed: 11 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -24,9 +24,18 @@ echo "$TRAVIS_NODE_VERSION"
2424
yarn --version
2525

2626
# Disable Xdebug except on code coverage jobs.
27-
if [[ ! "$ORCA_COVERAGE_ENABLE" ]]; then
27+
if [[ ! "$ORCA_COVERAGE_ENABLE" == TRUE ]]; then
2828
if [[ "$TRAVIS" ]]; then phpenv config-rm xdebug.ini; fi
29-
if [[ "$GITHUB_ACTIONS" ]]; then sudo phpdismod -v ALL xdebug; fi
29+
if [[ "$GITHUB_ACTIONS" ]]; then
30+
# phpdismod would be simpler but flaky
31+
# @see https://github.com/shivammathur/setup-php/issues/350#issuecomment-735370872
32+
scan_dir=$(php --ini | grep additional | sed -e "s|.*: s*||")
33+
ini_file=$(php --ini | grep "Loaded Configuration" | sed -e "s|.*:s*||" | sed "s/ //g")
34+
pecl_file="$scan_dir"/99-pecl.ini
35+
sudo sed -Ei "/xdebug/d" "${ini_file:?}"
36+
sudo sed -Ei "/xdebug/d" "${pecl_file:?}"
37+
sudo rm -rf "$scan_dir"/*xdebug*
38+
fi
3039
fi
3140

3241
# Travis CI installs YAML from PECL, but it's already present in GitHub Actions.

bin/ci/self-test/script.sh

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,17 @@ cd "$(dirname "$0")" || exit 1; source ../_includes.sh
1313

1414
cd ../../../ || exit 1
1515

16+
XDEBUG_IS_ENABLED=$(php -r 'echo function_exists("xdebug_get_code_coverage") ? "TRUE" : "FALSE";')
17+
18+
if [[ "$ORCA_COVERAGE_ENABLE" == TRUE && "$XDEBUG_IS_ENABLED" == "FALSE" ]]; then
19+
echo "ORCA_COVERAGE_ENABLE is on but Xdebug is disabled"
20+
exit 1
21+
fi
22+
23+
if [[ "$ORCA_COVERAGE_ENABLE" == FALSE && "$XDEBUG_IS_ENABLED" == "TRUE" ]]; then
24+
echo "ORCA_COVERAGE_ENABLE is off but Xdebug is enabled"
25+
exit 1
26+
fi
1627

1728
if [[ "$ORCA_JOB" == "STATIC_CODE_ANALYSIS" ]]; then
1829
./vendor/bin/phpcs

config/VERSION

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
v3.10.0
1+
v3.10.1

docs/CHANGELOG.md

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,13 @@
11
# Changelog
22

3+
## [v3.10.1](https://github.com/acquia/orca/tree/v3.10.1) (2021-10-01)
4+
5+
[Full Changelog](https://github.com/acquia/orca/compare/v3.10.0...v3.10.1)
6+
7+
**Fixed bugs:**
8+
9+
- Xdebug never disabled on Travis CI [\#159](https://github.com/acquia/orca/pull/159) ([danepowell](https://github.com/danepowell))
10+
311
## [v3.10.0](https://github.com/acquia/orca/tree/v3.10.0) (2021-09-29)
412

513
[Full Changelog](https://github.com/acquia/orca/compare/v3.9.0...v3.10.0)

0 commit comments

Comments
 (0)