diff --git a/app/__init__.py b/app/__init__.py index 2764c4cc8..ef5b0e780 100644 --- a/app/__init__.py +++ b/app/__init__.py @@ -31,4 +31,15 @@ def create_app(test_config=None): # Register Blueprints here + from .routes import task_bp + app.register_blueprint(task_bp) + + from .goal_routes import goal_bp + app.register_blueprint(goal_bp) + + # Register Models Here + # from app.models.task import Task + + # from app.models.goal import Goal + return app diff --git a/app/goal_routes.py b/app/goal_routes.py new file mode 100644 index 000000000..688974550 --- /dev/null +++ b/app/goal_routes.py @@ -0,0 +1,102 @@ +from flask import Blueprint, jsonify, make_response, request +from requests import session +from app.helpers import validate_goal, validate_task +from app.models.goal import Goal +from app import db +from app.models.task import Task + + +goal_bp = Blueprint("goal", __name__, url_prefix="/goals") + +# Create goal + + +@goal_bp.route("", methods=["POST"]) +def create_goal(): + request_body = request.get_json() + + if "title" not in request_body: + return { + "details": "Invalid data" + }, 400 + + new_goal = Goal.create(request_body) + + db.session.add(new_goal) + db.session.commit() + + return make_response(jsonify({"goal": new_goal.to_json()}), 201) + +# Get all goals + + +@goal_bp.route("", methods=["GET"]) +def get_all_goals(): + title_query = request.args.get("sort") + + if title_query == "asc": + goals = Goal.query.order_by(Goal.title.asc()) + elif title_query == "desc": + goals = Goal.query.order_by(Goal.title.desc()) + else: + goals = Goal.query.all() + + goals_response = [] + + for goal in goals: + goals_response.append(goal.to_json()) + + return jsonify(goals_response), 200 + +# Get one goal + + +@goal_bp.route("/", methods=["GET"]) +def get_one_goal(id): + goal = validate_goal(id) + return jsonify({"goal": goal.to_json()}), 200 + +# Update goal + + +@goal_bp.route("/", methods=["PUT"]) +def update_goal(id): + goal = validate_goal(id) + request_body = request.get_json() + + goal.update(request_body) + db.session.commit() + + return make_response(jsonify({"goal": goal.to_json()})), 200 + + +# Delete goal +@goal_bp.route("/", methods=["DELETE"]) +def delete_goal(id): + goal = validate_goal(id) + db.session.delete(goal) + db.session.commit() + + return make_response(jsonify({"details": f"Goal {id} \"{goal.title}\" successfully deleted"}), 200) + +# Sending a List of Task IDs to a Goal + + +@goal_bp.route("//tasks", methods=["POST"]) +def add_tasks_to_one_goal(id): + goal = validate_goal(id) + request_body = request.get_json() + + for id in request_body["id"]: + new_task = Task.query.get(id) + new_task.id = id + db.session.commit() + + list_of_task_ids = [] + for task in goal.tasks: + list_of_task_ids.append(task.id) + + return make_response(jsonify({"id": {new_task.id}, "task_ids": list_of_task_ids})), 200 + + +# @goal_bp.route("//tasks", methods=["POST"]) diff --git a/app/helpers.py b/app/helpers.py new file mode 100644 index 000000000..58a0ea38c --- /dev/null +++ b/app/helpers.py @@ -0,0 +1,30 @@ +from flask import make_response, abort +from app.models.task import Task +from app.models.goal import Goal + + +def validate_task(id): + try: + id = int(id) + except: + return abort(make_response({"details": f"Task is invalid"}, 400)) + + task = Task.query.get(id) + + if not task: + abort(make_response({"details": f"Task 1 not found"}, 404)) + + return task + + +def validate_goal(id): + try: + id = int(id) + except: + abort(make_response({"details": f"Goal is invalid"}, 400)) + + goal = Goal.query.get(id) + + if not goal: + abort(make_response({"details": f"Goal 1 not found"}, 404)) + return goal diff --git a/app/models/goal.py b/app/models/goal.py index b0ed11dd8..17fd1992c 100644 --- a/app/models/goal.py +++ b/app/models/goal.py @@ -1,5 +1,25 @@ + from app import db class Goal(db.Model): - goal_id = db.Column(db.Integer, primary_key=True) + id = db.Column(db.Integer, primary_key=True, autoincrement=True) + title = db.Column(db.String, nullable=False) + tasks = db.relationship("Task", back_populates="goals", lazy=True) + + def to_json(self): + return { + "id": self.id, + "title": self.title + } + + def update(self, request_body): + self.title = request_body["title"] + + @classmethod + def create(cls, request_body): + new_task = cls( + title=request_body["title"] + ) + + return new_task diff --git a/app/models/task.py b/app/models/task.py index c91ab281f..5280aa09f 100644 --- a/app/models/task.py +++ b/app/models/task.py @@ -1,5 +1,46 @@ + +from email.policy import default +from unittest.mock import DEFAULT from app import db +from .goal import Goal +from sqlalchemy.orm import relationship + +# DEFINING A MODEL +''' +Models in our Flask code will create a +direct connection between the data modeled in our +database. We will create a class for each model. +The class will define the state and behavior of our model. +''' class Task(db.Model): - task_id = db.Column(db.Integer, primary_key=True) + id = db.Column(db.Integer, primary_key=True, autoincrement=True) + title = db.Column(db.String) + description = db.Column(db.String) + completed_at = db.Column(db.DateTime, default=None) + goal_id = db.Column(db.Integer, db.ForeignKey("goal.id"), nullable=True) + goals = db.relationship("Goal", back_populates="tasks") + + def to_json(self): + return { + "id": self.id, + "title": self.title, + "description": self.description, + "is_complete": False if not self.completed_at else True + } + + def update(self, request_body): + self.title = request_body["title"] + self.description = request_body["description"] + # self.completed_at = request_body["completed_at"] + + @classmethod + def create(cls, request_body): + new_task = cls( + title=request_body['title'], + description=request_body['description'], + completed_at=request_body.get("completed_at", None) + ) + + return new_task diff --git a/app/routes.py b/app/routes.py index 3aae38d49..303af059f 100644 --- a/app/routes.py +++ b/app/routes.py @@ -1 +1,135 @@ -from flask import Blueprint \ No newline at end of file +from flask import Blueprint, jsonify, abort, make_response, request +from requests import session +from .helpers import validate_task +from app import db +from .models.task import Task +from datetime import datetime +import requests +import os + + +# TASK BLUEPRINT +''' +Blueprints are a Flask class that provides a pattern +for grouping related routes (endpoints) +''' + +task_bp = Blueprint("task", __name__, url_prefix="/tasks") + + +# Create a Task: Valid Task With null completed_at + +@task_bp.route("", methods=["POST"]) +def create_task(): + request_body = request.get_json() + + if "title" not in request_body: + return { + "details": "Invalid data" + }, 400 + if "description" not in request_body: + return { + "details": "Invalid data" + }, 400 + + new_task = Task.create(request_body) + + db.session.add(new_task) + db.session.commit() + + return make_response(jsonify({"task": new_task.to_json()}), 201) + + +# Get Tasks + +@task_bp.route("", methods=["POST", "GET"]) +def get_all_tasks(): + title_query = request.args.get("sort") + + # description_query=request.args.get("description") + + if title_query == "asc": + tasks = Task.query.order_by(Task.title.asc()) + elif title_query == "desc": + tasks = Task.query.order_by(Task.title.desc()) + else: + tasks = Task.query.all() + + # tasks_response = [task.to_dict() for task in tasks] + + tasks_response = [] + + for task in tasks: + tasks_response.append(task.to_json()) + + return jsonify(tasks_response), 200 + + +# Get One Task: One Saved Task +@task_bp.route("/", methods=["GET"]) +def get_one_task(id): + task = validate_task(id) + return jsonify({"task": task.to_json()}), 200 + + +# Update Task +@task_bp.route("/", methods=["PUT"]) +def update_task(id): + task = validate_task(id) + request_body = request.get_json() + + task.update(request_body) + db.session.commit() + + return make_response(jsonify({"task": task.to_json()}), 200) + + +# Delete Task: Deleting a Task +@task_bp.route("/", methods=["DELETE"]) +def delete_task(id): + task = validate_task(id) + db.session.delete(task) + db.session.commit() + + return make_response(jsonify({"details": f"Task {id} \"{task.title}\" successfully deleted"})) + +# Mark Complete + + +@task_bp.route("//mark_complete", methods=["PATCH"]) +def mark_complete(id): + task = validate_task(id) + + task.completed_at = datetime.utcnow() + + db.session.commit() + post_message_to_slack(task) + + return make_response(jsonify({"task": task.to_json()})), 200 + +# Slack + + +def post_message_to_slack(task): + send_msg_path = "https://slack.com/api/chat.postMessage" + confirm_message = f"You completed the task {task.title}!" + query_params = { + "channel": "task-notifications", + "text": confirm_message + } + headers = { + "Authorization": os.environ.get("slack_token") + } + requests.post(send_msg_path, params=query_params, headers=headers) + + +# Mark Incomplete +@task_bp.route("//mark_incomplete", methods=["PATCH"]) +def mark_incomplete(id): + task = validate_task(id) + + task.completed_at = None + + db.session.commit() + + return make_response(jsonify({"task": task.to_json()})), 200 diff --git a/migrations/README b/migrations/README new file mode 100644 index 000000000..0e0484415 --- /dev/null +++ b/migrations/README @@ -0,0 +1 @@ +Single-database configuration for Flask. diff --git a/migrations/alembic.ini b/migrations/alembic.ini new file mode 100644 index 000000000..ec9d45c26 --- /dev/null +++ b/migrations/alembic.ini @@ -0,0 +1,50 @@ +# A generic, single database configuration. + +[alembic] +# template used to generate migration files +# file_template = %%(rev)s_%%(slug)s + +# set to 'true' to run the environment during +# the 'revision' command, regardless of autogenerate +# revision_environment = false + + +# Logging configuration +[loggers] +keys = root,sqlalchemy,alembic,flask_migrate + +[handlers] +keys = console + +[formatters] +keys = generic + +[logger_root] +level = WARN +handlers = console +qualname = + +[logger_sqlalchemy] +level = WARN +handlers = +qualname = sqlalchemy.engine + +[logger_alembic] +level = INFO +handlers = +qualname = alembic + +[logger_flask_migrate] +level = INFO +handlers = +qualname = flask_migrate + +[handler_console] +class = StreamHandler +args = (sys.stderr,) +level = NOTSET +formatter = generic + +[formatter_generic] +format = %(levelname)-5.5s [%(name)s] %(message)s +datefmt = %H:%M:%S diff --git a/migrations/env.py b/migrations/env.py new file mode 100644 index 000000000..68feded2a --- /dev/null +++ b/migrations/env.py @@ -0,0 +1,91 @@ +from __future__ import with_statement + +import logging +from logging.config import fileConfig + +from flask import current_app + +from alembic import context + +# this is the Alembic Config object, which provides +# access to the values within the .ini file in use. +config = context.config + +# Interpret the config file for Python logging. +# This line sets up loggers basically. +fileConfig(config.config_file_name) +logger = logging.getLogger('alembic.env') + +# add your model's MetaData object here +# for 'autogenerate' support +# from myapp import mymodel +# target_metadata = mymodel.Base.metadata +config.set_main_option( + 'sqlalchemy.url', + str(current_app.extensions['migrate'].db.get_engine().url).replace( + '%', '%%')) +target_metadata = current_app.extensions['migrate'].db.metadata + +# other values from the config, defined by the needs of env.py, +# can be acquired: +# my_important_option = config.get_main_option("my_important_option") +# ... etc. + + +def run_migrations_offline(): + """Run migrations in 'offline' mode. + + This configures the context with just a URL + and not an Engine, though an Engine is acceptable + here as well. By skipping the Engine creation + we don't even need a DBAPI to be available. + + Calls to context.execute() here emit the given string to the + script output. + + """ + url = config.get_main_option("sqlalchemy.url") + context.configure( + url=url, target_metadata=target_metadata, literal_binds=True + ) + + with context.begin_transaction(): + context.run_migrations() + + +def run_migrations_online(): + """Run migrations in 'online' mode. + + In this scenario we need to create an Engine + and associate a connection with the context. + + """ + + # this callback is used to prevent an auto-migration from being generated + # when there are no changes to the schema + # reference: http://alembic.zzzcomputing.com/en/latest/cookbook.html + def process_revision_directives(context, revision, directives): + if getattr(config.cmd_opts, 'autogenerate', False): + script = directives[0] + if script.upgrade_ops.is_empty(): + directives[:] = [] + logger.info('No changes in schema detected.') + + connectable = current_app.extensions['migrate'].db.get_engine() + + with connectable.connect() as connection: + context.configure( + connection=connection, + target_metadata=target_metadata, + process_revision_directives=process_revision_directives, + **current_app.extensions['migrate'].configure_args + ) + + with context.begin_transaction(): + context.run_migrations() + + +if context.is_offline_mode(): + run_migrations_offline() +else: + run_migrations_online() diff --git a/migrations/script.py.mako b/migrations/script.py.mako new file mode 100644 index 000000000..2c0156303 --- /dev/null +++ b/migrations/script.py.mako @@ -0,0 +1,24 @@ +"""${message} + +Revision ID: ${up_revision} +Revises: ${down_revision | comma,n} +Create Date: ${create_date} + +""" +from alembic import op +import sqlalchemy as sa +${imports if imports else ""} + +# revision identifiers, used by Alembic. +revision = ${repr(up_revision)} +down_revision = ${repr(down_revision)} +branch_labels = ${repr(branch_labels)} +depends_on = ${repr(depends_on)} + + +def upgrade(): + ${upgrades if upgrades else "pass"} + + +def downgrade(): + ${downgrades if downgrades else "pass"} diff --git a/migrations/versions/7b9a420e4b55_starting_over_again.py b/migrations/versions/7b9a420e4b55_starting_over_again.py new file mode 100644 index 000000000..ab0b7dd16 --- /dev/null +++ b/migrations/versions/7b9a420e4b55_starting_over_again.py @@ -0,0 +1,40 @@ +"""starting over again + +Revision ID: 7b9a420e4b55 +Revises: +Create Date: 2022-05-12 21:07:47.315136 + +""" +from alembic import op +import sqlalchemy as sa + + +# revision identifiers, used by Alembic. +revision = '7b9a420e4b55' +down_revision = None +branch_labels = None +depends_on = None + + +def upgrade(): + # ### commands auto generated by Alembic - please adjust! ### + op.create_table('goal', + sa.Column('id', sa.Integer(), autoincrement=True, nullable=False), + sa.Column('title', sa.String(), nullable=False), + sa.PrimaryKeyConstraint('id') + ) + op.create_table('task', + sa.Column('id', sa.Integer(), autoincrement=True, nullable=False), + sa.Column('title', sa.String(), nullable=True), + sa.Column('description', sa.String(), nullable=True), + sa.Column('completed_at', sa.DateTime(), nullable=True), + sa.PrimaryKeyConstraint('id') + ) + # ### end Alembic commands ### + + +def downgrade(): + # ### commands auto generated by Alembic - please adjust! ### + op.drop_table('task') + op.drop_table('goal') + # ### end Alembic commands ### diff --git a/migrations/versions/c6e00cecd77e_added_foreign_key.py b/migrations/versions/c6e00cecd77e_added_foreign_key.py new file mode 100644 index 000000000..7d8d7f46a --- /dev/null +++ b/migrations/versions/c6e00cecd77e_added_foreign_key.py @@ -0,0 +1,30 @@ +"""added foreign key + +Revision ID: c6e00cecd77e +Revises: 7b9a420e4b55 +Create Date: 2022-05-12 21:15:23.534024 + +""" +from alembic import op +import sqlalchemy as sa + + +# revision identifiers, used by Alembic. +revision = 'c6e00cecd77e' +down_revision = '7b9a420e4b55' +branch_labels = None +depends_on = None + + +def upgrade(): + # ### commands auto generated by Alembic - please adjust! ### + op.add_column('task', sa.Column('goal_id', sa.Integer(), nullable=True)) + op.create_foreign_key(None, 'task', 'goal', ['goal_id'], ['id']) + # ### end Alembic commands ### + + +def downgrade(): + # ### commands auto generated by Alembic - please adjust! ### + op.drop_constraint(None, 'task', type_='foreignkey') + op.drop_column('task', 'goal_id') + # ### end Alembic commands ### diff --git a/requirements.txt b/requirements.txt index 30ff414fe..236f97bad 100644 --- a/requirements.txt +++ b/requirements.txt @@ -4,31 +4,45 @@ autopep8==1.5.5 blinker==1.4 certifi==2020.12.5 chardet==4.0.0 -click==7.1.2 -Flask==1.1.2 -Flask-Migrate==2.6.0 -Flask-SQLAlchemy==2.4.4 +charset-normalizer==2.0.12 +click==8.1.3 +coverage==5.5 +cowsay==4.0 +distlib==0.3.4 +filelock==3.6.0 +Flask==2.1.2 +Flask-Migrate==3.1.0 +Flask-SQLAlchemy==2.5.1 gunicorn==20.1.0 idna==2.10 +importlib-metadata==4.11.3 iniconfig==1.1.1 -itsdangerous==1.1.0 -Jinja2==2.11.3 +itsdangerous==2.1.2 +Jinja2==3.1.2 Mako==1.1.4 -MarkupSafe==1.1.1 +MarkupSafe==2.1.1 packaging==20.9 +platformdirs==2.5.1 pluggy==0.13.1 -psycopg2-binary==2.8.6 +pprintpp==0.4.0 +psycopg2-binary==2.9.3 py==1.10.0 pycodestyle==2.6.0 pyparsing==2.4.7 -pytest==6.2.3 +pytest==7.1.2 pytest-cov==2.12.1 +pytest-flask==1.2.0 python-dateutil==2.8.1 python-dotenv==0.15.0 python-editor==1.0.4 requests==2.25.1 +simplejson==3.17.6 six==1.15.0 SQLAlchemy==1.3.23 toml==0.10.2 +tomli==2.0.1 urllib3==1.26.5 -Werkzeug==1.0.1 +virtualenv==20.13.4 +Werkzeug==2.1.2 +wonderwords==2.2.0 +zipp==3.8.0 diff --git a/tests/test_wave_01.py b/tests/test_wave_01.py index dca626d78..abe07f370 100644 --- a/tests/test_wave_01.py +++ b/tests/test_wave_01.py @@ -2,7 +2,7 @@ import pytest -@pytest.mark.skip(reason="No way to test this feature yet") +# @pytest.mark.skip(reason="No way to test this feature yet") def test_get_tasks_no_saved_tasks(client): # Act response = client.get("/tasks") @@ -13,7 +13,7 @@ def test_get_tasks_no_saved_tasks(client): assert response_body == [] -@pytest.mark.skip(reason="No way to test this feature yet") +# @pytest.mark.skip(reason="No way to test this feature yet") def test_get_tasks_one_saved_tasks(client, one_task): # Act response = client.get("/tasks") @@ -32,7 +32,7 @@ def test_get_tasks_one_saved_tasks(client, one_task): ] -@pytest.mark.skip(reason="No way to test this feature yet") +# @pytest.mark.skip(reason="No way to test this feature yet") def test_get_task(client, one_task): # Act response = client.get("/tasks/1") @@ -51,7 +51,7 @@ def test_get_task(client, one_task): } -@pytest.mark.skip(reason="No way to test this feature yet") +# @pytest.mark.skip(reason="No way to test this feature yet") def test_get_task_not_found(client): # Act response = client.get("/tasks/1") @@ -60,13 +60,18 @@ def test_get_task_not_found(client): # Assert assert response.status_code == 404 - raise Exception("Complete test with assertion about response body") + # raise Exception("Complete test with assertion about response body") # ***************************************************************** # **Complete test with assertion about response body*************** # ***************************************************************** + assert "details" in response_body + assert response_body == {"details": f"Task 1 not found"} + assert Task.query.get(1) == None + +# @pytest.mark.skip(reason="No way to test this feature yet") + -@pytest.mark.skip(reason="No way to test this feature yet") def test_create_task(client): # Act response = client.post("/tasks", json={ @@ -93,7 +98,7 @@ def test_create_task(client): assert new_task.completed_at == None -@pytest.mark.skip(reason="No way to test this feature yet") +# @pytest.mark.skip(reason="No way to test this feature yet") def test_update_task(client, one_task): # Act response = client.put("/tasks/1", json={ @@ -119,7 +124,7 @@ def test_update_task(client, one_task): assert task.completed_at == None -@pytest.mark.skip(reason="No way to test this feature yet") +# @pytest.mark.skip(reason="No way to test this feature yet") def test_update_task_not_found(client): # Act response = client.put("/tasks/1", json={ @@ -131,13 +136,14 @@ def test_update_task_not_found(client): # Assert assert response.status_code == 404 - raise Exception("Complete test with assertion about response body") + # raise Exception("Complete test with assertion about response body") # ***************************************************************** # **Complete test with assertion about response body*************** # ***************************************************************** + assert response_body == {"details": "Task 1 not found"} -@pytest.mark.skip(reason="No way to test this feature yet") +# @pytest.mark.skip(reason="No way to test this feature yet") def test_delete_task(client, one_task): # Act response = client.delete("/tasks/1") @@ -152,7 +158,7 @@ def test_delete_task(client, one_task): assert Task.query.get(1) == None -@pytest.mark.skip(reason="No way to test this feature yet") +# @pytest.mark.skip(reason="No way to test this feature yet") def test_delete_task_not_found(client): # Act response = client.delete("/tasks/1") @@ -161,15 +167,15 @@ def test_delete_task_not_found(client): # Assert assert response.status_code == 404 - raise Exception("Complete test with assertion about response body") + # raise Exception("Complete test with assertion about response body") # ***************************************************************** # **Complete test with assertion about response body*************** # ***************************************************************** - assert Task.query.all() == [] + assert response_body == {"details": "Task 1 not found"} -@pytest.mark.skip(reason="No way to test this feature yet") +# @pytest.mark.skip(reason="No way to test this feature yet") def test_create_task_must_contain_title(client): # Act response = client.post("/tasks", json={ @@ -186,7 +192,7 @@ def test_create_task_must_contain_title(client): assert Task.query.all() == [] -@pytest.mark.skip(reason="No way to test this feature yet") +# @pytest.mark.skip(reason="No way to test this feature yet") def test_create_task_must_contain_description(client): # Act response = client.post("/tasks", json={ diff --git a/tests/test_wave_02.py b/tests/test_wave_02.py index a087e0909..651e3aebd 100644 --- a/tests/test_wave_02.py +++ b/tests/test_wave_02.py @@ -1,7 +1,7 @@ import pytest -@pytest.mark.skip(reason="No way to test this feature yet") +# @pytest.mark.skip(reason="No way to test this feature yet") def test_get_tasks_sorted_asc(client, three_tasks): # Act response = client.get("/tasks?sort=asc") @@ -29,7 +29,7 @@ def test_get_tasks_sorted_asc(client, three_tasks): ] -@pytest.mark.skip(reason="No way to test this feature yet") +# @pytest.mark.skip(reason="No way to test this feature yet") def test_get_tasks_sorted_desc(client, three_tasks): # Act response = client.get("/tasks?sort=desc") diff --git a/tests/test_wave_03.py b/tests/test_wave_03.py index 959176ceb..55ac82606 100644 --- a/tests/test_wave_03.py +++ b/tests/test_wave_03.py @@ -5,7 +5,7 @@ import pytest -@pytest.mark.skip(reason="No way to test this feature yet") +# @pytest.mark.skip(reason="No way to test this feature yet") def test_mark_complete_on_incomplete_task(client, one_task): # Arrange """ @@ -42,7 +42,7 @@ def test_mark_complete_on_incomplete_task(client, one_task): assert Task.query.get(1).completed_at -@pytest.mark.skip(reason="No way to test this feature yet") +# @pytest.mark.skip(reason="No way to test this feature yet") def test_mark_incomplete_on_complete_task(client, completed_task): # Act response = client.patch("/tasks/1/mark_incomplete") @@ -62,7 +62,7 @@ def test_mark_incomplete_on_complete_task(client, completed_task): assert Task.query.get(1).completed_at == None -@pytest.mark.skip(reason="No way to test this feature yet") +# @pytest.mark.skip(reason="No way to test this feature yet") def test_mark_complete_on_completed_task(client, completed_task): # Arrange """ @@ -99,7 +99,7 @@ def test_mark_complete_on_completed_task(client, completed_task): assert Task.query.get(1).completed_at -@pytest.mark.skip(reason="No way to test this feature yet") +# @pytest.mark.skip(reason="No way to test this feature yet") def test_mark_incomplete_on_incomplete_task(client, one_task): # Act response = client.patch("/tasks/1/mark_incomplete") @@ -119,7 +119,7 @@ def test_mark_incomplete_on_incomplete_task(client, one_task): assert Task.query.get(1).completed_at == None -@pytest.mark.skip(reason="No way to test this feature yet") +# @pytest.mark.skip(reason="No way to test this feature yet") def test_mark_complete_missing_task(client): # Act response = client.patch("/tasks/1/mark_complete") @@ -128,13 +128,14 @@ def test_mark_complete_missing_task(client): # Assert assert response.status_code == 404 - raise Exception("Complete test with assertion about response body") + # raise Exception("Complete test with assertion about response body") # ***************************************************************** # **Complete test with assertion about response body*************** # ***************************************************************** + assert {'details': 'Task 1 not found'} -@pytest.mark.skip(reason="No way to test this feature yet") +# @pytest.mark.skip(reason="No way to test this feature yet") def test_mark_incomplete_missing_task(client): # Act response = client.patch("/tasks/1/mark_incomplete") @@ -143,7 +144,7 @@ def test_mark_incomplete_missing_task(client): # Assert assert response.status_code == 404 - raise Exception("Complete test with assertion about response body") + # raise Exception("Complete test with assertion about response body") # ***************************************************************** # **Complete test with assertion about response body*************** # ***************************************************************** @@ -151,7 +152,7 @@ def test_mark_incomplete_missing_task(client): # Let's add this test for creating tasks, now that # the completion functionality has been implemented -@pytest.mark.skip(reason="No way to test this feature yet") +# @pytest.mark.skip(reason="No way to test this feature yet") def test_create_task_with_valid_completed_at(client): # Act response = client.post("/tasks", json={ @@ -181,7 +182,7 @@ def test_create_task_with_valid_completed_at(client): # Let's add this test for updating tasks, now that # the completion functionality has been implemented -@pytest.mark.skip(reason="No way to test this feature yet") +# @pytest.mark.skip(reason="No way to test this feature yet") def test_update_task_with_completed_at_date(client, completed_task): # Act response = client.put("/tasks/1", json={ diff --git a/tests/test_wave_05.py b/tests/test_wave_05.py index aee7c52a1..f9f7001d7 100644 --- a/tests/test_wave_05.py +++ b/tests/test_wave_05.py @@ -1,7 +1,8 @@ +from app.models.goal import Goal import pytest -@pytest.mark.skip(reason="No way to test this feature yet") +# @pytest.mark.skip(reason="No way to test this feature yet") def test_get_goals_no_saved_goals(client): # Act response = client.get("/goals") @@ -12,7 +13,7 @@ def test_get_goals_no_saved_goals(client): assert response_body == [] -@pytest.mark.skip(reason="No way to test this feature yet") +# @pytest.mark.skip(reason="No way to test this feature yet") def test_get_goals_one_saved_goal(client, one_goal): # Act response = client.get("/goals") @@ -29,7 +30,7 @@ def test_get_goals_one_saved_goal(client, one_goal): ] -@pytest.mark.skip(reason="No way to test this feature yet") +# @pytest.mark.skip(reason="No way to test this feature yet") def test_get_goal(client, one_goal): # Act response = client.get("/goals/1") @@ -46,22 +47,24 @@ def test_get_goal(client, one_goal): } -@pytest.mark.skip(reason="test to be completed by student") +# @pytest.mark.skip(reason="test to be completed by student") def test_get_goal_not_found(client): pass # Act response = client.get("/goals/1") response_body = response.get_json() - raise Exception("Complete test") + # raise Exception("Complete test") # Assert # ---- Complete Test ---- - # assertion 1 goes here - # assertion 2 goes here + assert response.status_code == 404 + assert "details" in response_body + assert response_body == {"details": f"Goal 1 not found"} + assert Goal.query.get(1) == None # ---- Complete Test ---- -@pytest.mark.skip(reason="No way to test this feature yet") +# @pytest.mark.skip(reason="No way to test this feature yet") def test_create_goal(client): # Act response = client.post("/goals", json={ @@ -80,71 +83,82 @@ def test_create_goal(client): } -@pytest.mark.skip(reason="test to be completed by student") +# @pytest.mark.skip(reason="test to be completed by student") def test_update_goal(client, one_goal): - raise Exception("Complete test") + # raise Exception("Complete test") # Act # ---- Complete Act Here ---- + response = client.put("/goals/1", json={ + "title": "Updated Goal Title" + }) + response_body = response.get_json() # Assert # ---- Complete Assertions Here ---- - # assertion 1 goes here - # assertion 2 goes here - # assertion 3 goes here + assert response.status_code == 200 + assert "goal" in response_body + assert response_body == { + "goal": { + "id": 1, + "title": "Updated Goal Title" + } + } + goal = Goal.query.get(1) + assert goal.title == "Updated Goal Title" # ---- Complete Assertions Here ---- -@pytest.mark.skip(reason="test to be completed by student") +# @pytest.mark.skip(reason="test to be completed by student") def test_update_goal_not_found(client): - raise Exception("Complete test") + # raise Exception("Complete test") # Act # ---- Complete Act Here ---- - + response = client.put("/goals/1", json={ + "title": "Updated Goal Title", + }) + response_body = response.get_json() # Assert # ---- Complete Assertions Here ---- - # assertion 1 goes here - # assertion 2 goes here + assert response.status_code == 404 + assert response_body == {"details": "Goal 1 not found"} # ---- Complete Assertions Here ---- -@pytest.mark.skip(reason="No way to test this feature yet") +# @pytest.mark.skip(reason="No way to test this feature yet") def test_delete_goal(client, one_goal): # Act response = client.delete("/goals/1") response_body = response.get_json() - # Assert + # raise Exception("Complete test with assertion about response body") + # ***************************************************************** + # **Complete test with assertion about response body*************** + # ***************************************************************** assert response.status_code == 200 assert "details" in response_body assert response_body == { "details": 'Goal 1 "Build a habit of going outside daily" successfully deleted' } - - # Check that the goal was deleted - response = client.get("/goals/1") - assert response.status_code == 404 - - raise Exception("Complete test with assertion about response body") - # ***************************************************************** - # **Complete test with assertion about response body*************** - # ***************************************************************** + assert Goal.query.get(1) == None -@pytest.mark.skip(reason="test to be completed by student") +# @pytest.mark.skip(reason="test to be completed by student") def test_delete_goal_not_found(client): - raise Exception("Complete test") + # raise Exception("Complete test") # Act # ---- Complete Act Here ---- + response = client.delete("/goals/1") + response_body = response.get_json() # Assert # ---- Complete Assertions Here ---- - # assertion 1 goes here - # assertion 2 goes here + assert response.status_code == 404 + assert response_body == {"details": "Goal 1 not found"} # ---- Complete Assertions Here ---- -@pytest.mark.skip(reason="No way to test this feature yet") +# @pytest.mark.skip(reason="No way to test this feature yet") def test_create_goal_missing_title(client): # Act response = client.post("/goals", json={}) diff --git a/tests/test_wave_06.py b/tests/test_wave_06.py index 8afa4325e..566c52a39 100644 --- a/tests/test_wave_06.py +++ b/tests/test_wave_06.py @@ -2,7 +2,7 @@ import pytest -@pytest.mark.skip(reason="No way to test this feature yet") +# @pytest.mark.skip(reason="No way to test this feature yet") def test_post_task_ids_to_goal(client, one_goal, three_tasks): # Act response = client.post("/goals/1/tasks", json={