further reduce unnecessary string copies

Author: anonrig

include/ada/url_pattern-inl.h

@@ -9,7 +9,9 @@
 #include "ada/url_pattern_helpers.h"
 #include "ada/url_pattern.h"
 
+#include <algorithm>
 #include <string_view>
+#include <utility>
 
 namespace ada {
 
@@ -330,36 +332,34 @@ result<std::optional<url_pattern_result>> url_pattern<regex_provider>::match(
     // https://github.com/cloudflare/workerd/blob/8620d14012513a6ce04d079e401d3becac3c67bd/src/workerd/jsg/url.c%2B%2B#L2038
     protocol = url->get_protocol().substr(0, url->get_protocol().size() - 1);
     // Set username to url’s username.
-    username = url->get_username();
+    username = std::move(url->get_username());
     // Set password to url’s password.
-    password = url->get_password();
+    password = std::move(url->get_password());
     // Set hostname to url’s host, serialized, or the empty string if the value
     // is null.
-    hostname = url->get_hostname();
+    hostname = std::move(url->get_hostname());
     // Set port to url’s port, serialized, or the empty string if the value is
     // null.
-    port = url->get_port();
+    port = std::move(url->get_port());
     // Set pathname to the result of URL path serializing url.
-    pathname = url->get_pathname();
+    pathname = std::move(url->get_pathname());
     // Set search to url’s query or the empty string if the value is null.
     // IMPORTANT: Not documented on the URLPattern spec, but search prefix '?'
     // is removed. Similar work was done on workerd:
     // https://github.com/cloudflare/workerd/blob/8620d14012513a6ce04d079e401d3becac3c67bd/src/workerd/jsg/url.c%2B%2B#L2232
     if (url->has_search()) {
       auto view = url->get_search();
-      search = view.starts_with("?") ? url->get_search().substr(1) : view;
-    } else {
-      search = "";
+      search =
+          view.starts_with("?") ? url->get_search().substr(1) : std::move(view);
     }
     // Set hash to url’s fragment or the empty string if the value is null.
     // IMPORTANT: Not documented on the URLPattern spec, but hash prefix '#' is
     // removed. Similar work was done on workerd:
     // https://github.com/cloudflare/workerd/blob/8620d14012513a6ce04d079e401d3becac3c67bd/src/workerd/jsg/url.c%2B%2B#L2242
     if (url->has_hash()) {
       auto view = url->get_hash();
-      hash = view.starts_with("#") ? url->get_hash().substr(1) : view;
-    } else {
-      hash = "";
+      hash =
+          view.starts_with("#") ? url->get_hash().substr(1) : std::move(view);
     }
   }
 

src/url_pattern_helpers.cpp

@@ -15,7 +15,6 @@ generate_regular_expression_and_name_list(
 
   // Let name list be a new list
   std::vector<std::string> name_list{};
-  const std::string full_wildcard_regexp_value = ".*";
 
   // For each part of part list:
   for (const url_pattern_part& part : part_list) {
@@ -61,7 +60,7 @@ generate_regular_expression_and_name_list(
     // Otherwise if part's type is "full-wildcard"
     else if (part.type == url_pattern_part_type::FULL_WILDCARD) {
       // then set regexp value to full wildcard regexp value.
-      regexp_value = full_wildcard_regexp_value;
+      regexp_value = ".*";
     }
 
     // If part's prefix is the empty string and part's suffix is the empty
@@ -140,7 +139,7 @@ generate_regular_expression_and_name_list(
   result += "$";
 
   // Return (result, name list)
-  return {result, name_list};
+  return {std::move(result), std::move(name_list)};
 }
 
 bool is_ipv6_address(std::string_view input) noexcept {