feat(ui,dashboard): Move InlineTip to UI package (medusajs#11462)

Author: kasperkristensen

.changeset/seven-nails-sleep.md

@@ -0,0 +1,6 @@
+---
+"@medusajs/ui": patch
+"@medusajs/dashboard": patch
+---
+
+feat(ui,dashboard): Move InlineTip to UI package

packages/admin/dashboard/src/components/common/inline-tip/inline-tip.tsx

@@ -4,6 +4,7 @@ import {
   DropdownMenu,
   Heading,
   IconButton,
+  InlineTip,
   clx,
   toast,
 } from "@medusajs/ui"
@@ -21,7 +22,6 @@ import { FetchError } from "@medusajs/js-sdk"
 import { ComponentPropsWithoutRef, forwardRef } from "react"
 import { ConditionalTooltip } from "../../common/conditional-tooltip"
 import { Form } from "../../common/form"
-import { InlineTip } from "../../common/inline-tip"
 import { Skeleton } from "../../common/skeleton"
 import { RouteDrawer, useRouteModal } from "../../modals"
 import { KeyboundForm } from "../../utilities/keybound-form"

packages/admin/dashboard/src/components/forms/metadata-form/metadata-form.tsx

@@ -1,8 +1,8 @@
-import { Input, Switch } from "@medusajs/ui"
+import { InlineTip, Input, Switch } from "@medusajs/ui"
 import { ComponentType } from "react"
 import { ControllerRenderProps, UseFormReturn } from "react-hook-form"
+import { useTranslation } from "react-i18next"
 import { Form } from "../../../components/common/form"
-import { InlineTip } from "../../../components/common/inline-tip"
 import { FormField } from "../../types"
 import { FormFieldType } from "./types"
 import { getFieldType } from "./utils"
@@ -86,6 +86,8 @@ const FormExtensionFieldComponent = ({
   component,
   placeholder,
 }: FormExtensionFieldComponentProps) => {
+  const { t } = useTranslation()
+
   if (component) {
     const Component = component
 
@@ -104,7 +106,7 @@ const FormExtensionFieldComponent = ({
     }
     default: {
       return (
-        <InlineTip variant="warning">
+        <InlineTip variant="warning" label={t("general.warning")}>
           The field type does not support rendering a fallback component. Please
           provide a component prop.
         </InlineTip>

packages/admin/dashboard/src/extensions/forms/form-extension-zone/form-extension-zone.tsx

@@ -1,12 +1,11 @@
 import { zodResolver } from "@hookform/resolvers/zod"
 import { HttpTypes } from "@medusajs/types"
-import { Button, Heading, Input, toast } from "@medusajs/ui"
+import { Button, Heading, InlineTip, Input, toast } from "@medusajs/ui"
 import { useForm } from "react-hook-form"
 import { useTranslation } from "react-i18next"
 import { z } from "zod"
 
 import { Form } from "../../../../../components/common/form"
-import { InlineTip } from "../../../../../components/common/inline-tip"
 import {
   RouteFocusModal,
   StackedFocusModal,
@@ -118,7 +117,7 @@ export function CreateServiceZoneForm({
                   />
                 </div>
 
-                <InlineTip>
+                <InlineTip label={t("general.tip")}>
                   {t("stockLocations.serviceZones.fields.tip")}
                 </InlineTip>
 

packages/admin/dashboard/src/routes/locations/location-service-zone-create/components/create-service-zone-form/create-service-zone-form.tsx

@@ -1,11 +1,10 @@
 import { HttpTypes } from "@medusajs/types"
-import { Button, Input, toast } from "@medusajs/ui"
+import { Button, InlineTip, Input, toast } from "@medusajs/ui"
 import { useForm } from "react-hook-form"
 import { useTranslation } from "react-i18next"
 import * as zod from "zod"
 
 import { Form } from "../../../../../components/common/form"
-import { InlineTip } from "../../../../../components/common/inline-tip"
 import { RouteDrawer, useRouteModal } from "../../../../../components/modals"
 import { KeyboundForm } from "../../../../../components/utilities/keybound-form"
 import { useUpdateFulfillmentSetServiceZone } from "../../../../../hooks/api/fulfillment-sets"
@@ -83,7 +82,9 @@ export const EditServiceZoneForm = ({
                 }}
               />
             </div>
-            <InlineTip>{t("stockLocations.serviceZones.fields.tip")}</InlineTip>
+            <InlineTip label={t("general.tip")}>
+              {t("stockLocations.serviceZones.fields.tip")}
+            </InlineTip>
           </div>
         </RouteDrawer.Body>
         <RouteDrawer.Footer>

packages/admin/dashboard/src/routes/locations/location-service-zone-edit/components/edit-region-form/edit-service-zone-form.tsx

@@ -6,6 +6,7 @@ import {
   Heading,
   Hint,
   IconButton,
+  InlineTip,
   Input,
   Label,
   Text,
@@ -21,7 +22,6 @@ import {
 import { useTranslation } from "react-i18next"
 
 import { Form } from "../../../../../../../components/common/form"
-import { InlineTip } from "../../../../../../../components/common/inline-tip"
 import { SortableList } from "../../../../../../../components/common/sortable-list"
 import { SwitchBox } from "../../../../../../../components/common/switch-box"
 import { ChipInput } from "../../../../../../../components/inputs/chip-input"
@@ -522,7 +522,7 @@ export const ProductCreateVariantsSection = ({
                 </Alert>
               )}
               {variants.fields.length > 0 && (
-                <InlineTip variant="tip">
+                <InlineTip label={t("general.tip")}>
                   {t("products.create.variants.productVariants.tip")}
                 </InlineTip>
               )}

packages/admin/dashboard/src/routes/products/product-create/components/product-create-details-form/components/product-create-details-variant-section/product-create-details-variant-section.tsx

@@ -0,0 +1,37 @@
+import { render, screen } from "@testing-library/react"
+import * as React from "react"
+import { InlineTip } from "./inline-tip"
+
+describe("InlineTip", () => {
+  it("renders a InlineTip", () => {
+    render(<InlineTip label="Test">This is a test</InlineTip>)
+    expect(screen.getByText("This is a test")).toBeInTheDocument()
+  })
+
+  it("renders a InlineTip with a warning variant", () => {
+    render(
+      <InlineTip variant="warning" label="Test">
+        This is a test
+      </InlineTip>
+    )
+    expect(screen.getByText("This is a test")).toBeInTheDocument()
+  })
+
+  it("renders a InlineTip with an error variant", () => {
+    render(
+      <InlineTip variant="error" label="Test">
+        This is a test
+      </InlineTip>
+    )
+    expect(screen.getByText("This is a test")).toBeInTheDocument()
+  })
+
+  it("renders a InlineTip with a success variant", () => {
+    render(
+      <InlineTip variant="success" label="Test">
+        This is a test
+      </InlineTip>
+    )
+    expect(screen.getByText("This is a test")).toBeInTheDocument()
+  })
+})

packages/admin/dashboard/src/components/common/inline-tip/index.ts packages/design-system/ui/src/components/inline-tip/index.ts

@@ -0,0 +1,58 @@
+import type { Meta, StoryObj } from "@storybook/react"
+import * as React from "react"
+import { InlineTip } from "./inline-tip"
+
+const meta: Meta<typeof InlineTip> = {
+  title: "Components/InlineTip",
+  component: InlineTip,
+  parameters: {
+    layout: "centered",
+  },
+  render: (args) => {
+    return (
+      <div className="flex max-w-md">
+        <InlineTip {...args} />
+      </div>
+    )
+  },
+}
+
+export default meta
+
+type Story = StoryObj<typeof InlineTip>
+
+export const Info: Story = {
+  args: {
+    variant: "info",
+    label: "Info",
+    children:
+      "You can always install the storefront at a later point. Medusa is a headless backend, so it operates without a storefront by default. You can connect any storefront to it. The Next.js Starter storefront is a good option to use, but you can also build your own storefront later on.",
+  },
+}
+
+export const Warning: Story = {
+  args: {
+    variant: "warning",
+    label: "Warning",
+    children:
+      "If you have multiple storage plugins configured, the last plugin declared in the medusa-config.js file will be used.",
+  },
+}
+
+export const Error: Story = {
+  args: {
+    variant: "error",
+    label: "Don'ts",
+    children:
+      "Don’t use data models if you want to store simple key-value pairs related to a Medusa data model. Instead, use the metadata field that modles have, which is an object of custom key-value pairs.",
+  },
+}
+
+export const Success: Story = {
+  args: {
+    variant: "success",
+    label: "Do's",
+    children:
+      "Use data models when you want to store data related to your customization in the database.",
+  },
+}

packages/design-system/ui/src/components/inline-tip/inline-tip.spec.tsx

@@ -0,0 +1,47 @@
+import { clx } from "@/utils/clx"
+import * as React from "react"
+
+interface InlineTipProps extends React.ComponentPropsWithoutRef<"div"> {
+  /**
+   * The label to display in the tip.
+   */
+  label: string
+  /**
+   * The variant of the tip.
+   * @default "info"
+   */
+  variant?: "info" | "warning" | "error" | "success"
+}
+
+/**
+ * This component is based on the `div` element and supports all of its props.
+ */
+export const InlineTip = React.forwardRef<HTMLDivElement, InlineTipProps>(
+  ({ variant = "info", label, className, children, ...props }, ref) => {
+    return (
+      <div
+        ref={ref}
+        className={clx(
+          "bg-ui-bg-component txt-small text-ui-fg-subtle grid grid-cols-[4px_1fr] items-start gap-3 rounded-lg border p-3",
+          className
+        )}
+        {...props}
+      >
+        <div
+          role="presentation"
+          className={clx("bg-ui-tag-neutral-icon h-full w-1 rounded-full", {
+            "bg-ui-tag-orange-icon": variant === "warning",
+            "bg-ui-tag-red-icon": variant === "error",
+            "bg-ui-tag-green-icon": variant === "success",
+          })}
+        />
+        <div className="text-pretty">
+          <strong className="txt-small-plus text-ui-fg-base">{label}:</strong>{" "}
+          {children}
+        </div>
+      </div>
+    )
+  }
+)
+
+InlineTip.displayName = "InlineTip"

packages/design-system/ui/src/components/inline-tip/inline-tip.stories.tsx

@@ -22,6 +22,7 @@ export { Hint } from "./components/hint"
 export { I18nProvider } from "./components/i18n-provider"
 export { IconBadge } from "./components/icon-badge"
 export { IconButton } from "./components/icon-button"
+export { InlineTip } from "./components/inline-tip"
 export { Input } from "./components/input"
 export { Kbd } from "./components/kbd"
 export { Label } from "./components/label"