fix(medusa,utils,test-utils,types,framework,dashboard,admin-vite-plugin,admin-bundler): Fix broken plugin dependencies in development server (medusajs#11720)

**What**
- Reworks how admin extensions are loaded from plugins.
- Reworks how extensions are managed internally in the dashboard project.

**Why**
- Previously we loaded extensions from plugins the same way we do for extension found in a users application. This being scanning the source code for possible extensions in `.medusa/server/src/admin`, and including any extensions that were discovered in the final virtual modules.
- This was causing issues with how Vite optimizes dependencies, and would lead to CJS/ESM issues. Not sure of the exact cause of this, but the issue was pinpointed to Vite not being able to register correctly which dependencies to optimize when they were loaded through the virtual module from a plugin in `node_modules`.

**What changed**
- To circumvent the above issue we have changed to a different strategy for loading extensions from plugins. The changes are the following:
  - We now build plugins slightly different, if a plugin has admin extensions we now build those to `.medusa/server/src/admin/index.mjs` and `.medusa/server/src/admin/index.js` for a ESM and CJS build.
  - When determining how to load extensions from a source we follow these rules:
    - If the source has a `medusa-plugin-options.json` or is the root application we determine that it is a `local` extension source, and load extensions as previously through a virtual module.
    - If it has neither of the above, but has a `./admin` export in its package.json then we determine that it is a `package` extension, and we update the entry point for the dashboard to import the package and pass its extensions a long to the dashboard manager.

**Changes required by plugin authors**
- The change has no breaking changes, but requires plugin authors to update the `package.json` of their plugins to also include a `./admin` export. It should look like this:

```json
{
  "name": "@medusajs/plugin",
  "version": "0.0.1",
  "description": "A starter for Medusa plugins.",
  "author": "Medusa (https://medusajs.com)",
  "license": "MIT",
  "files": [
    ".medusa/server"
  ],
  "exports": {
    "./package.json": "./package.json",
    "./workflows": "./.medusa/server/src/workflows/index.js",
    "./.medusa/server/src/modules/*": "./.medusa/server/src/modules/*/index.js",
    "./modules/*": "./.medusa/server/src/modules/*/index.js",
    "./providers/*": "./.medusa/server/src/providers/*/index.js",
    "./*": "./.medusa/server/src/*.js",
    "./admin": {
      "import": "./.medusa/server/src/admin/index.mjs",
      "require": "./.medusa/server/src/admin/index.js",
      "default": "./.medusa/server/src/admin/index.js"
    }
  },
}
```

Author: kasperkristensen

.changeset/cold-keys-press.md

@@ -0,0 +1,12 @@
+---
+"@medusajs/admin-vite-plugin": patch
+"@medusajs/admin-bundler": patch
+"@medusajs/test-utils": patch
+"@medusajs/dashboard": patch
+"@medusajs/framework": patch
+"@medusajs/types": patch
+"@medusajs/utils": patch
+"@medusajs/medusa": patch
+---
+
+fix(medusa,utils,test-utils,types,framework,dashboard,admin-vite-plugin,admib-bundler): Fix broken plugin dependencies in development server

packages/admin/admin-bundler/package.json

@@ -4,7 +4,7 @@
   "description": "Bundler for the Medusa admin dashboard.",
   "author": "Kasper Kristensen <[email protected]>",
   "scripts": {
-    "build": "tsup && copyfiles -f ./src/index.html ./src/entry.tsx ./src/index.css ./dist"
+    "build": "tsup"
   },
   "main": "./dist/index.js",
   "types": "./dist/index.d.ts",
@@ -20,7 +20,6 @@
   "devDependencies": {
     "@medusajs/types": "2.6.1",
     "@types/compression": "^1.7.5",
-    "copyfiles": "^2.4.1",
     "express": "^4.21.0",
     "tsup": "^8.0.1",
     "typescript": "^5.3.3"
@@ -29,19 +28,16 @@
     "@medusajs/admin-shared": "2.6.1",
     "@medusajs/admin-vite-plugin": "2.6.1",
     "@medusajs/dashboard": "2.6.1",
-    "@rollup/plugin-node-resolve": "^16.0.0",
     "@vitejs/plugin-react": "^4.2.1",
     "autoprefixer": "^10.4.16",
     "compression": "^1.7.4",
     "express": "^4.21.0",
     "get-port": "^5.1.1",
     "glob": "^10.3.10",
+    "outdent": "^0.8.0",
     "postcss": "^8.4.32",
     "tailwindcss": "^3.3.6",
     "vite": "^5.4.14"
   },
-  "peerDependencies": {
-    "react-dom": "^18.0.0"
-  },
   "packageManager": "[email protected]"
 }

packages/admin/admin-bundler/src/lib/build.ts packages/admin/admin-bundler/src/commands/build.ts

@@ -1,6 +1,6 @@
 import type { InlineConfig } from "vite"
 import { BundlerOptions } from "../types"
-import { getViteConfig } from "./config"
+import { getViteConfig } from "../utils/config"
 
 export async function build(options: BundlerOptions) {
   const vite = await import("vite")

packages/admin/admin-bundler/src/lib/develop.ts packages/admin/admin-bundler/src/commands/develop.ts

@@ -4,7 +4,7 @@ import path from "path"
 import type { InlineConfig, ViteDevServer } from "vite"
 
 import { BundlerOptions } from "../types"
-import { getViteConfig } from "./config"
+import { getViteConfig } from "../utils/config"
 
 const router = express.Router()
 

packages/admin/admin-bundler/src/commands/plugin.ts

@@ -0,0 +1,112 @@
+import { readFileSync } from "fs"
+import { builtinModules } from "node:module"
+import path from "path"
+import type { UserConfig } from "vite"
+import { clearPluginBuild } from "../plugins/clear-plugin-build"
+
+interface PluginOptions {
+  root: string
+  outDir: string
+}
+
+export async function plugin(options: PluginOptions) {
+  const vite = await import("vite")
+  const react = (await import("@vitejs/plugin-react")).default
+  const medusa = (await import("@medusajs/admin-vite-plugin")).default
+
+  const pkg = JSON.parse(
+    readFileSync(path.resolve(options.root, "package.json"), "utf-8")
+  )
+  const external = new Set([
+    ...Object.keys(pkg.dependencies || {}),
+    ...Object.keys(pkg.peerDependencies || {}),
+    ...Object.keys(pkg.devDependencies || {}),
+    "react",
+    "react/jsx-runtime",
+    "react-router-dom",
+    "@medusajs/js-sdk",
+    "@medusajs/admin-sdk",
+    "@tanstack/react-query",
+  ])
+
+  const outDir = path.resolve(options.root, options.outDir, "src/admin")
+  const entryPoint = path.resolve(
+    options.root,
+    "src/admin/__admin-extensions__.js"
+  )
+
+  /**
+   * We need to ensure that the NODE_ENV is set to production,
+   * otherwise Vite will build the dev version of React.
+   */
+  const originalNodeEnv = process.env.NODE_ENV
+  process.env.NODE_ENV = "production"
+
+  const pluginConfig: UserConfig = {
+    build: {
+      lib: {
+        entry: entryPoint,
+        formats: ["es", "cjs"],
+        fileName: "index",
+      },
+      emptyOutDir: false,
+      minify: false,
+      outDir,
+      rollupOptions: {
+        external: (id, importer) => {
+          // If there's no importer, it's a direct dependency
+          // Keep the existing external behavior
+          if (!importer) {
+            const idParts = id.split("/")
+            const name = idParts[0]?.startsWith("@")
+              ? `${idParts[0]}/${idParts[1]}`
+              : idParts[0]
+
+            const builtinModulesWithNodePrefix = [
+              ...builtinModules,
+              ...builtinModules.map((modName) => `node:${modName}`),
+            ]
+
+            return Boolean(
+              (name && external.has(name)) ||
+                (name && builtinModulesWithNodePrefix.includes(name))
+            )
+          }
+
+          // For transient dependencies (those with importers),
+          // bundle them if they're not in our external set
+          const idParts = id.split("/")
+          const name = idParts[0]?.startsWith("@")
+            ? `${idParts[0]}/${idParts[1]}`
+            : idParts[0]
+
+          return Boolean(name && external.has(name))
+        },
+        output: {
+          preserveModules: false,
+          interop: "auto",
+          chunkFileNames: () => {
+            return `_chunks/[name]-[hash]`
+          },
+        },
+      },
+    },
+    plugins: [
+      react(),
+      medusa({
+        pluginMode: true,
+        sources: [path.resolve(options.root, "src/admin")],
+      }),
+      clearPluginBuild({ outDir }),
+    ],
+    logLevel: "silent",
+    clearScreen: false,
+  }
+
+  await vite.build(pluginConfig)
+
+  /**
+   * Restore the original NODE_ENV
+   */
+  process.env.NODE_ENV = originalNodeEnv
+}

packages/admin/admin-bundler/src/lib/serve.ts packages/admin/admin-bundler/src/commands/serve.ts

@@ -1,6 +1,6 @@
-export { build } from "./lib/build"
-export { develop } from "./lib/develop"
-export { plugin } from "./lib/plugin"
-export { serve } from "./lib/serve"
+export { build } from "./commands/build"
+export { develop } from "./commands/develop"
+export { plugin } from "./commands/plugin"
+export { serve } from "./commands/serve"
 
 export * from "./types"

packages/admin/admin-bundler/src/entry.tsx

@@ -0,0 +1,19 @@
+import { rm } from "node:fs/promises"
+import path from "node:path"
+import type { Plugin } from "vite"
+
+interface ClearPluginBuildOptions {
+  outDir: string
+}
+
+export const clearPluginBuild = (options: ClearPluginBuildOptions): Plugin => ({
+  name: "medusa:clear-plugin-build",
+  buildStart: async () => {
+    const adminDir = path.join(options.outDir, "admin")
+    try {
+      await rm(adminDir, { recursive: true, force: true })
+    } catch (e) {
+      // Directory might not exist, ignore
+    }
+  },
+})