Does @react-aria/test-utils require that we utilize testing-library/react?

[stevegreco]

I have a question around the usage of @react-aria/test-utils and testing-library. I know that it utilizes testing-library internally, but does that mean we have to utilize it as well in our project?

We have recently been experimenting with vitest-browser-react instead of testing-library. The main problem I see is when assigning the root element.

// testing-library
   const select = user.createTester("Select", {
        root: screen.getByTestId("select"),
        interactionType: interaction,
      });

// vitest-browser-react
  const combobox = user.createTester("ComboBox", {
        root: screen.getByTestId("combobox").element() as HTMLElement,
        interactionType: interaction,
      });

This will sometimes cause errors like

Error: Listbox with id of null not found in document.

I know this package is still in beta, but I am curious if anyone has gotten this working

[LFDanLu]

The package was built with testing-library specifically in mind, but its definitely an interesting idea to see if I can have it support vitest-browser-react too since the APIs are so similar. I'll have to play around with this idea though first, I'm not familiar with vitest-browser-react at all really

[stevegreco]

At first glance everything seems to be working, I ran all my test flake scripts and I have not gotten any failures. I would agree with the sentiment in the PR that making @testing-library/dom a peerDep would not be ideal. One of the advantages of using vitest-browser-react is being able to remove the testing library deps.

I trust your judgement here, just wanted to give my opinion on that piece.

[LFDanLu]

thank you for giving it a try, its good to hear that flakiness seems to have disappeared. We'll revisit the peer dep, just wanted to ship a nightly ASAP haha

[stevegreco]

No problem, always willing to test it out. Is there an issue to track for this? I can probably mark this discussion as resolved, but just wanted to make sure you had what you need.

[LFDanLu]

yep, I'm tracking this via #9700, thanks once again!

[LFDanLu]

Closing in favor of tracking this work in #9700