Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor C/C++ build process for expat, zlib, and C++ XMP Toolkit #197

Closed
scouten-adobe opened this issue Feb 23, 2024 · 1 comment · Fixed by #216
Closed

Refactor C/C++ build process for expat, zlib, and C++ XMP Toolkit #197

scouten-adobe opened this issue Feb 23, 2024 · 1 comment · Fixed by #216
Assignees
@scouten-adobe
Labels
help wanted Extra attention is needed

Comments

@scouten-adobe
Copy link
Member

Per feedback on rust-lang/cc-rs#959, looks like we will need to deeply rework the build.rs script so as to not depend on undocumented aspects of its build process.

Currently pinning release to ≤1.0.83 until that is resolved.
@scouten-adobe scouten-adobe self-assigned this Feb 23, 2024
@scouten-adobe scouten-adobe added the help wanted Extra attention is needed label Feb 23, 2024
@scouten-adobe scouten-adobe mentioned this issue Feb 23, 2024
Closed
@NobodyXu
Copy link

NobodyXu commented Apr 7, 2024

Maybe you could switch to cc::Build::compile_intermediates, since it would give you the filenames of objects generated

@uttarayan21 uttarayan21 mentioned this issue May 1, 2024
Closed
3 tasks
@scouten scouten mentioned this issue Jun 20, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@scouten-adobe scouten-adobe

Labels
help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update for current cc crate adobe/xmp-toolkit-rs
2 participants
@NobodyXu @scouten-adobe