Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MWPW-151416 - [LocUI] skip URL validation Language tiles #2379

Merged
merged 1 commit into from
May 29, 2024

Conversation

Sartxi
Copy link
Contributor

@Sartxi Sartxi commented May 29, 2024

We are only validating the URLs in the project configuration to avoid creation of project with bad URLs. We can assume the langstore URLs will be available based on the config being valid. I have updated the url component to make sure the url was validated before showing any errors.

Resolves: MWPW-151416

Copy link
Contributor

aem-code-sync bot commented May 29, 2024

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

Copy link

codecov bot commented May 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.68%. Comparing base (3a137ca) to head (4ebea97).
Report is 761 commits behind head on locui.

Additional details and impacted files
@@            Coverage Diff             @@
##            locui    #2379      +/-   ##
==========================================
- Coverage   96.20%   95.68%   -0.53%     
==========================================
  Files         135      165      +30     
  Lines       33267    43538   +10271     
==========================================
+ Hits        32006    41661    +9655     
- Misses       1261     1877     +616     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Sartxi Sartxi merged commit 475f4f4 into locui May 29, 2024
12 of 14 checks passed
@Sartxi Sartxi deleted the sartxi/url-validation-fix branch May 29, 2024 21:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants