-
Notifications
You must be signed in to change notification settings - Fork 181
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MWPW-153586 - [LocUI] Validation and URL Actions state #2569
Conversation
Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## locui #2569 +/- ##
==========================================
- Coverage 96.20% 95.68% -0.53%
==========================================
Files 135 165 +30
Lines 33267 43538 +10271
==========================================
+ Hits 32006 41661 +9655
- Misses 1261 1877 +616 ☔ View full report in Codecov by Sentry. |
URL action buttons need better state management. This PR adds better action button state management and updates the validation of both configured URLs and URLs returned in find fragments to verify the page exists and is the same origin.
Resolves: MWPW-153586
Fragment Validation:
https://sean-loc--milo--adobecom.hlx.page/tools/loc?ref=main&repo=milo&owner=adobecom&host=milo.adobe.com&project=Milo&referrer=https%3A%2F%2Fadobe.sharepoint.com%2F%3Ax%3A%2Fr%2Fsites%2Fadobecom%2F_layouts%2F15%2FDoc.aspx%3Fsourcedoc%3D%257B183689e0-de1c-41a7-be6f-cc16e477b2fc%257D%26action%3Deditnew%26wdsle%3D0
URLs Validation:
https://sean-loc--milo--adobecom.hlx.page/tools/loc?ref=main&repo=milo&owner=adobecom&host=milo.adobe.com&project=Milo&referrer=https%3A%2F%2Fadobe.sharepoint.com%2F%3Ax%3A%2Fr%2Fsites%2Fadobecom%2F_layouts%2F15%2FDoc.aspx%3Fsourcedoc%3D%257B25CBF365-16EF-4190-B278-35614F0ACD35%257D%26file%3DUrls%2520404s%2520sync%25201.xlsx%26action%3Ddefault%26mobileredirect%3Dtrue%26wdsle%3D0