-
Notifications
You must be signed in to change notification settings - Fork 181
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MWPW-154891 - [LocUI] Check if media in URL Validation #2631
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## locui #2631 +/- ##
==========================================
- Coverage 96.20% 95.68% -0.53%
==========================================
Files 135 165 +30
Lines 33267 43538 +10271
==========================================
+ Hits 32006 41661 +9655
- Misses 1261 1877 +616 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see a label check is failing; that requirement has been removed for a while now from the Milo repo, so it might be that locui
needs a rebase with stage
or main
. Is that a possibility or would the list of conflicts be unmanageable at this point?
I will rebase ASAP, thanks! |
Add a layer of validation for media files against URLs and fragment URLs on init and in fragment search.
Resolves: MWPW-154891
Test URLs:
https://main--cc--adobecom.hlx.page/tools/loc?milolibs=sean-loc&ref=main&repo=cc&owner=aishwaryamathuria&host=www.adobe.com&project=Creative+Cloud&referrer=https%3A%2F%2Fadobe.sharepoint.com%2F%3Ax%3A%2Fr%2Fsites%2Fadobecom%2F_layouts%2F15%2FDoc.aspx%3Fsourcedoc%3D%257B684b46f2-c806-465e-8568-44f1bbb608e9%257D%26action%3Deditnew