Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MWPW-154891 - [LocUI] Check if media in URL Validation #2631

Merged
merged 3 commits into from
Jul 30, 2024

Conversation

@Sartxi Sartxi added the bug Something isn't working label Jul 25, 2024
Copy link
Contributor

aem-code-sync bot commented Jul 25, 2024

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

Copy link

codecov bot commented Jul 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.68%. Comparing base (3a137ca) to head (b1c23c7).
Report is 774 commits behind head on locui.

Additional details and impacted files
@@            Coverage Diff             @@
##            locui    #2631      +/-   ##
==========================================
- Coverage   96.20%   95.68%   -0.53%     
==========================================
  Files         135      165      +30     
  Lines       33267    43538   +10271     
==========================================
+ Hits        32006    41661    +9655     
- Misses       1261     1877     +616     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aem-code-sync aem-code-sync bot temporarily deployed to sartxi/MWPW-154891-media July 25, 2024 19:48 Inactive
Copy link
Contributor

@overmyheadandbody overmyheadandbody left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see a label check is failing; that requirement has been removed for a while now from the Milo repo, so it might be that locui needs a rebase with stage or main. Is that a possibility or would the list of conflicts be unmanageable at this point?

@Sartxi
Copy link
Contributor Author

Sartxi commented Jul 30, 2024

I see a label check is failing; that requirement has been removed for a while now from the Milo repo, so it might be that locui needs a rebase with stage or main. Is that a possibility or would the list of conflicts be unmanageable at this point?

I will rebase ASAP, thanks!

@Sartxi Sartxi merged commit 0871d8b into locui Jul 30, 2024
9 of 12 checks passed
@Sartxi Sartxi deleted the sartxi/MWPW-154891-media branch July 30, 2024 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants