Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MWPW-155676 - [LocUI] Find duplicate fragments by pathname #2681

Merged
merged 1 commit into from
Aug 1, 2024

Conversation

Sartxi
Copy link
Contributor

@Sartxi Sartxi commented Aug 1, 2024

Due to the video fragments having URL params the de-dupe function was seeing them as different because it was checking the URL href property instead of the pathname. Updating the duplicate function to look at only the pathname to avoid this.

Resolves: MWPW-155676

Test URLs:
https://main--cc--adobecom.hlx.page/tools/loc?milolibs=sean-loc&ref=main&repo=cc&owner=adobecom&host=www.adobe.com&project=Creative+Cloud&referrer=https%3A%2F%2Fadobe.sharepoint.com%2F%3Ax%3A%2Fr%2Fsites%2Fadobecom%2F_layouts%2F15%2FDoc.aspx%3Fsourcedoc%3D%257B170d251e-8672-4185-b0b7-440ed60908f9%257D%26action%3Deditnew

@Sartxi Sartxi added the bug Something isn't working label Aug 1, 2024
@Sartxi Sartxi requested a review from auniverseaway August 1, 2024 16:13
Copy link
Contributor

aem-code-sync bot commented Aug 1, 2024

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

Copy link

codecov bot commented Aug 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.68%. Comparing base (3a137ca) to head (4360989).
Report is 775 commits behind head on locui.

Additional details and impacted files
@@            Coverage Diff             @@
##            locui    #2681      +/-   ##
==========================================
- Coverage   96.20%   95.68%   -0.53%     
==========================================
  Files         135      165      +30     
  Lines       33267    43538   +10271     
==========================================
+ Hits        32006    41660    +9654     
- Misses       1261     1878     +617     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Sartxi Sartxi merged commit fb03c2b into locui Aug 1, 2024
10 of 14 checks passed
@Sartxi Sartxi deleted the sartxi/MWPW-155676-video-frags branch August 1, 2024 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants