Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MWPW-153372 - Add ability to further customize buttons #2776

Merged
merged 8 commits into from
Sep 2, 2024

Conversation

elan-tbx
Copy link
Contributor

@elan-tbx elan-tbx commented Aug 21, 2024

  • After some discussion, a pattern has been agreed upon for extending our button styles beyond the base 3 (text link, outlined button, filled button). For now, the main variant that this PR enables is the "black-filled" style, which already had preexisting CSS written for it in styles.css, but it opens the door for additional customizations in the future.
  • The authoring pattern for this is simply adding #_button-{style} to the end of the button's URL. In the case of the black-filled button, for example, it would be #_button-fill. Whatever is in the style part of the tag will be applied as a CSS class to the button, via the decorateButtons() function.
  • Note that this should not interfere with other link customizations such as #_dnt or modal links -- multiple tags can be added to a single link, and there is documented precedent for doing this already in Milo (see the "Link Features" tab of this authoring documentation)

Resolves: MWPW-153372

Test URLs:

@elan-tbx elan-tbx added run-nala Run Nala Test Automation against PR needs-verification PR requires E2E testing by a reviewer labels Aug 21, 2024
@elan-tbx elan-tbx requested a review from a team as a code owner August 21, 2024 20:22
Copy link
Contributor

aem-code-sync bot commented Aug 21, 2024

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

Copy link
Contributor

aem-code-sync bot commented Aug 21, 2024

@aem-code-sync aem-code-sync bot temporarily deployed to ebartholomew/MWPW-153372-custom-btns August 21, 2024 20:27 Inactive
Copy link

codecov bot commented Aug 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.91%. Comparing base (0ae86a3) to head (0c8cfae).
Report is 17 commits behind head on stage.

Additional details and impacted files
@@            Coverage Diff             @@
##            stage    #2776      +/-   ##
==========================================
+ Coverage   95.89%   95.91%   +0.02%     
==========================================
  Files         173      173              
  Lines       45853    45852       -1     
==========================================
+ Hits        43969    43979      +10     
+ Misses       1884     1873      -11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aem-code-sync aem-code-sync bot temporarily deployed to ebartholomew/MWPW-153372-custom-btns August 21, 2024 20:54 Inactive
@aem-code-sync aem-code-sync bot temporarily deployed to ebartholomew/MWPW-153372-custom-btns August 22, 2024 14:17 Inactive
@elan-tbx elan-tbx requested a review from robert-bogos August 22, 2024 14:22
@aem-code-sync aem-code-sync bot temporarily deployed to ebartholomew/MWPW-153372-custom-btns August 22, 2024 20:26 Inactive
Revert "MWPW-151936 - Aside Tiger Team Enhancements (redux) (#2767)"

This reverts commit 88cb101.
@aem-code-sync aem-code-sync bot temporarily deployed to ebartholomew/MWPW-153372-custom-btns August 22, 2024 20:27 Inactive
@aem-code-sync aem-code-sync bot temporarily deployed to ebartholomew/MWPW-153372-custom-btns August 22, 2024 21:21 Inactive
@SilviuLCF SilviuLCF self-requested a review August 26, 2024 08:42
Copy link
Contributor

@ryanmparrish ryanmparrish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amen 🙏

Copy link
Contributor

This PR is currently in the needs-verification state. Please assign a QA engineer to verify the changes.

Copy link

@SilviuLCF SilviuLCF left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified , ready to STAGE
Testing details: https://jira.corp.adobe.com/browse/MWPW-153372

@SilviuLCF SilviuLCF added Ready for Stage verified PR has been E2E tested by a reviewer and removed needs-verification PR requires E2E testing by a reviewer labels Aug 27, 2024
@milo-pr-merge milo-pr-merge bot merged commit 4e85f88 into stage Sep 2, 2024
21 checks passed
@milo-pr-merge milo-pr-merge bot deleted the ebartholomew/MWPW-153372-custom-btns branch September 2, 2024 08:18
@milo-pr-merge milo-pr-merge bot mentioned this pull request Sep 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ready for Stage run-nala Run Nala Test Automation against PR verified PR has been E2E tested by a reviewer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants