-
Notifications
You must be signed in to change notification settings - Fork 181
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MWPW-158872 : NALA] Update Nala GitHub Action runs to correctly handle bot-generated PR details. #2930
Conversation
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## stage #2930 +/- ##
==========================================
+ Coverage 96.24% 96.28% +0.03%
==========================================
Files 236 239 +3
Lines 54278 54669 +391
==========================================
+ Hits 52241 52639 +398
+ Misses 2037 2030 -7 ☔ View full report in Codecov by Sentry. |
This PR does not qualify for the zero-impact label as it touches code outside of the allowed areas. The label is auto applied, do not manually apply the label. |
This PR does not qualify for the zero-impact label as it touches code outside of the allowed areas. The label is auto applied, do not manually apply the label. |
Addressing this with #2936 - zero impact PRs are auto labeled |
console.error(`Error => Error in setting PR Branch test URL : ${prBranchLiveUrl}`); | ||
console.info(`Note: PR branch test url ${prBranchLiveUrl} is not valid, Exiting test execution.`); | ||
console.error( | ||
`Error => Error in setting PR Branch test URL : ${prBranchLiveUrl}`, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why do we need the additional ,
here? Same for some of the other console messages.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@narcis-radu : The additional comma is required to adhere Eslint comma-dangle
, rule
Test URLs: