Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MWPW-158872 : NALA] Update Nala GitHub Action runs to correctly handle bot-generated PR details. #2930

Merged
merged 4 commits into from
Sep 24, 2024

Conversation

skumar09
Copy link
Contributor

  • Update Nala global.setup.js for GitHub Action run to handle Bot generated PR ( Stage->Main) correctly

Test URLs:

Copy link
Contributor

aem-code-sync bot commented Sep 21, 2024

Page Scores Audits Google
📱 /?martech=off PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
🖥️ /?martech=off PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

Copy link

codecov bot commented Sep 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.28%. Comparing base (1791eb8) to head (e2dde92).
Report is 5 commits behind head on stage.

Additional details and impacted files
@@            Coverage Diff             @@
##            stage    #2930      +/-   ##
==========================================
+ Coverage   96.24%   96.28%   +0.03%     
==========================================
  Files         236      239       +3     
  Lines       54278    54669     +391     
==========================================
+ Hits        52241    52639     +398     
+ Misses       2037     2030       -7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

This PR does not qualify for the zero-impact label as it touches code outside of the allowed areas. The label is auto applied, do not manually apply the label.

Copy link
Contributor

This PR does not qualify for the zero-impact label as it touches code outside of the allowed areas. The label is auto applied, do not manually apply the label.

@mokimo
Copy link
Contributor

mokimo commented Sep 23, 2024

@skumar09 skumar09 added the zero-impact label 3 days ago

Addressing this with #2936 - zero impact PRs are auto labeled

console.error(`Error => Error in setting PR Branch test URL : ${prBranchLiveUrl}`);
console.info(`Note: PR branch test url ${prBranchLiveUrl} is not valid, Exiting test execution.`);
console.error(
`Error => Error in setting PR Branch test URL : ${prBranchLiveUrl}`,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why do we need the additional , here? Same for some of the other console messages.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@narcis-radu : The additional comma is required to adhere Eslint comma-dangle, rule

@milo-pr-merge milo-pr-merge bot merged commit b600045 into adobecom:stage Sep 24, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants