From bd23cbb660e9ccc56db0d208737bcdfb8baa8b70 Mon Sep 17 00:00:00 2001 From: Rohit Sahu Date: Thu, 24 Oct 2024 12:31:41 +0530 Subject: [PATCH 1/9] Add "Save now" to the OST CTAs options --- libs/blocks/ost/ctaTextOption.js | 1 + test/blocks/ost/textOption.test.js | 3 ++- 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/libs/blocks/ost/ctaTextOption.js b/libs/blocks/ost/ctaTextOption.js index 1fa7450362..7d7807bd26 100644 --- a/libs/blocks/ost/ctaTextOption.js +++ b/libs/blocks/ost/ctaTextOption.js @@ -12,6 +12,7 @@ const ctaTextOption = { { id: 'take-the-quiz', name: 'Take the quiz' }, { id: 'see-more', name: 'See more' }, { id: 'upgrade-now', name: 'Upgrade now' }, + { id: 'save-now', name: 'Save now' }, ], getDefaultText() { diff --git a/test/blocks/ost/textOption.test.js b/test/blocks/ost/textOption.test.js index 9254a74b21..f5a87f0f63 100644 --- a/test/blocks/ost/textOption.test.js +++ b/test/blocks/ost/textOption.test.js @@ -20,7 +20,8 @@ describe('test ctaTextOption', () => { { id: 'change-plan-team-payment', name: 'Change Plan Team Payment' }, { id: 'take-the-quiz', name: 'Take the quiz' }, { id: 'see-more', name: 'See more' }, - { id: 'upgrade-now', name: 'Upgrade now' }]; + { id: 'upgrade-now', name: 'Upgrade now' }, + { id: 'save-now', name: 'Save now' }]; const texts = ctaTextOption.getTexts(); expect(EXPECTED_TEXTS).to.deep.equal(texts); }); From 80b197ea3aac66329bdb247e60cc2d1dad212848 Mon Sep 17 00:00:00 2001 From: Rohit Sahu Date: Thu, 24 Oct 2024 14:28:33 +0530 Subject: [PATCH 2/9] review comment --- libs/blocks/ost/ctaTextOption.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libs/blocks/ost/ctaTextOption.js b/libs/blocks/ost/ctaTextOption.js index 7d7807bd26..23dc858cb0 100644 --- a/libs/blocks/ost/ctaTextOption.js +++ b/libs/blocks/ost/ctaTextOption.js @@ -3,6 +3,7 @@ const ctaTextOption = { { id: 'buy-now', name: 'Buy now' }, { id: 'free-trial', name: 'Free trial' }, { id: 'start-free-trial', name: 'Start free trial' }, + { id: 'save-now', name: 'Save now' }, { id: 'get-started', name: 'Get started' }, { id: 'choose-a-plan', name: 'Choose a plan' }, { id: 'learn-more', name: 'Learn more' }, @@ -12,7 +13,6 @@ const ctaTextOption = { { id: 'take-the-quiz', name: 'Take the quiz' }, { id: 'see-more', name: 'See more' }, { id: 'upgrade-now', name: 'Upgrade now' }, - { id: 'save-now', name: 'Save now' }, ], getDefaultText() { From 4dc7f83964113597fa67b22910673047eb865606 Mon Sep 17 00:00:00 2001 From: Rohit Sahu Date: Thu, 24 Oct 2024 14:33:33 +0530 Subject: [PATCH 3/9] UT fix --- test/blocks/ost/textOption.test.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/test/blocks/ost/textOption.test.js b/test/blocks/ost/textOption.test.js index f5a87f0f63..c1de3a4bd3 100644 --- a/test/blocks/ost/textOption.test.js +++ b/test/blocks/ost/textOption.test.js @@ -12,6 +12,7 @@ describe('test ctaTextOption', () => { const EXPECTED_TEXTS = [{ id: 'buy-now', name: 'Buy now' }, { id: 'free-trial', name: 'Free trial' }, { id: 'start-free-trial', name: 'Start free trial' }, + { id: 'save-now', name: 'Save now' }, { id: 'get-started', name: 'Get started' }, { id: 'choose-a-plan', name: 'Choose a plan' }, { id: 'learn-more', name: 'Learn more' }, @@ -20,8 +21,7 @@ describe('test ctaTextOption', () => { { id: 'change-plan-team-payment', name: 'Change Plan Team Payment' }, { id: 'take-the-quiz', name: 'Take the quiz' }, { id: 'see-more', name: 'See more' }, - { id: 'upgrade-now', name: 'Upgrade now' }, - { id: 'save-now', name: 'Save now' }]; + { id: 'upgrade-now', name: 'Upgrade now' }]; const texts = ctaTextOption.getTexts(); expect(EXPECTED_TEXTS).to.deep.equal(texts); }); From a73f1e5861f636e0756142155f30911f3d2c3ff1 Mon Sep 17 00:00:00 2001 From: Rohit Sahu Date: Thu, 24 Oct 2024 14:40:47 +0530 Subject: [PATCH 4/9] dummy commit --- test/blocks/ost/textOption.test.js | 1 + 1 file changed, 1 insertion(+) diff --git a/test/blocks/ost/textOption.test.js b/test/blocks/ost/textOption.test.js index c1de3a4bd3..80d004137a 100644 --- a/test/blocks/ost/textOption.test.js +++ b/test/blocks/ost/textOption.test.js @@ -22,6 +22,7 @@ describe('test ctaTextOption', () => { { id: 'take-the-quiz', name: 'Take the quiz' }, { id: 'see-more', name: 'See more' }, { id: 'upgrade-now', name: 'Upgrade now' }]; + const texts = ctaTextOption.getTexts(); expect(EXPECTED_TEXTS).to.deep.equal(texts); }); From 62a2949720d52863a69968a0b324eb1940cbcd22 Mon Sep 17 00:00:00 2001 From: Rohit Sahu Date: Thu, 24 Oct 2024 14:41:00 +0530 Subject: [PATCH 5/9] Revert "dummy commit" This reverts commit a73f1e5861f636e0756142155f30911f3d2c3ff1. --- test/blocks/ost/textOption.test.js | 1 - 1 file changed, 1 deletion(-) diff --git a/test/blocks/ost/textOption.test.js b/test/blocks/ost/textOption.test.js index 80d004137a..c1de3a4bd3 100644 --- a/test/blocks/ost/textOption.test.js +++ b/test/blocks/ost/textOption.test.js @@ -22,7 +22,6 @@ describe('test ctaTextOption', () => { { id: 'take-the-quiz', name: 'Take the quiz' }, { id: 'see-more', name: 'See more' }, { id: 'upgrade-now', name: 'Upgrade now' }]; - const texts = ctaTextOption.getTexts(); expect(EXPECTED_TEXTS).to.deep.equal(texts); }); From 24c3d4b62feb0d0286c0e1a774bddf70fe9f5ca3 Mon Sep 17 00:00:00 2001 From: Rohit Sahu Date: Thu, 24 Oct 2024 14:54:17 +0530 Subject: [PATCH 6/9] dummy commit for intermittent test failure --- libs/blocks/notification/notification.js | 1 + 1 file changed, 1 insertion(+) diff --git a/libs/blocks/notification/notification.js b/libs/blocks/notification/notification.js index 8dd8ceb5bf..6cab7cb2c0 100644 --- a/libs/blocks/notification/notification.js +++ b/libs/blocks/notification/notification.js @@ -17,6 +17,7 @@ import { decorateBlockText, decorateBlockBg, decorateTextOverrides, decorateMultiViewport, loadCDT } from '../../utils/decorate.js'; import { createTag, getConfig, loadStyle } from '../../utils/utils.js'; + const { miloLibs, codeRoot } = getConfig(); const base = miloLibs || codeRoot; const variants = ['banner', 'ribbon', 'pill']; From 9004b006e4d84d26c2b696277244cb5ca00e401c Mon Sep 17 00:00:00 2001 From: Rohit Sahu Date: Thu, 24 Oct 2024 14:54:41 +0530 Subject: [PATCH 7/9] Revert "dummy commit for intermittent test failure" This reverts commit 24c3d4b62feb0d0286c0e1a774bddf70fe9f5ca3. --- libs/blocks/notification/notification.js | 1 - 1 file changed, 1 deletion(-) diff --git a/libs/blocks/notification/notification.js b/libs/blocks/notification/notification.js index 6cab7cb2c0..8dd8ceb5bf 100644 --- a/libs/blocks/notification/notification.js +++ b/libs/blocks/notification/notification.js @@ -17,7 +17,6 @@ import { decorateBlockText, decorateBlockBg, decorateTextOverrides, decorateMultiViewport, loadCDT } from '../../utils/decorate.js'; import { createTag, getConfig, loadStyle } from '../../utils/utils.js'; - const { miloLibs, codeRoot } = getConfig(); const base = miloLibs || codeRoot; const variants = ['banner', 'ribbon', 'pill']; From 8d2d7bceaee35b261404667a27e278d31966e7ce Mon Sep 17 00:00:00 2001 From: Rohit Sahu Date: Thu, 24 Oct 2024 14:40:47 +0530 Subject: [PATCH 8/9] dummy commit (cherry picked from commit a73f1e5861f636e0756142155f30911f3d2c3ff1) --- test/blocks/ost/textOption.test.js | 1 + 1 file changed, 1 insertion(+) diff --git a/test/blocks/ost/textOption.test.js b/test/blocks/ost/textOption.test.js index c1de3a4bd3..80d004137a 100644 --- a/test/blocks/ost/textOption.test.js +++ b/test/blocks/ost/textOption.test.js @@ -22,6 +22,7 @@ describe('test ctaTextOption', () => { { id: 'take-the-quiz', name: 'Take the quiz' }, { id: 'see-more', name: 'See more' }, { id: 'upgrade-now', name: 'Upgrade now' }]; + const texts = ctaTextOption.getTexts(); expect(EXPECTED_TEXTS).to.deep.equal(texts); }); From 4c3d8972452e73da1bf793d567b73750cac3c7f2 Mon Sep 17 00:00:00 2001 From: Rohit Sahu Date: Thu, 24 Oct 2024 14:59:11 +0530 Subject: [PATCH 9/9] Revert "dummy commit" This reverts commit 8d2d7bceaee35b261404667a27e278d31966e7ce. --- test/blocks/ost/textOption.test.js | 1 - 1 file changed, 1 deletion(-) diff --git a/test/blocks/ost/textOption.test.js b/test/blocks/ost/textOption.test.js index 80d004137a..c1de3a4bd3 100644 --- a/test/blocks/ost/textOption.test.js +++ b/test/blocks/ost/textOption.test.js @@ -22,7 +22,6 @@ describe('test ctaTextOption', () => { { id: 'take-the-quiz', name: 'Take the quiz' }, { id: 'see-more', name: 'See more' }, { id: 'upgrade-now', name: 'Upgrade now' }]; - const texts = ctaTextOption.getTexts(); expect(EXPECTED_TEXTS).to.deep.equal(texts); });