update screenshot diff failed (#376)

adobecom · Jun 11, 2024 · 800e576 · 800e576
1 parent b91293a
commit 800e576
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/libs/screenshot/compare.mjs b/libs/screenshot/compare.mjs
@@ -5,7 +5,7 @@ import path from 'path';
 import fs from 'fs';
 
 const S3URL = 'https://s3-sj3.corp.adobe.com/milo';
-const ALLOWED_BASE_DIRECTORY = 'screenshots/';
+const ALLOWED_BASE_DIRECTORY = 'screenshots';
 
 function sanitizeAndValidateFilePath(filePath) {
   if (typeof filePath !== 'string') {

diff --git a/libs/screenshot/utils.js b/libs/screenshot/utils.js
@@ -4,7 +4,7 @@ const { getComparator } = require('playwright-core/lib/utils');
 const fs = require('fs');
 const path = require('path');
 
-const ALLOWED_BASE_DIRECTORY = 'screenshots/';
+const ALLOWED_BASE_DIRECTORY = 'screenshots';
 
 function validatePath(filePath, options = { allowDirectory: false, forWriting: false }) {
   if (typeof filePath !== 'string') {
@@ -64,7 +64,7 @@ function compareScreenshots(stableArray, betaArray) {
 
       if (diffImage) {
         result.diff = `${stableArray[i].a}-diff.png`;
-        fs.writeFileSync(validatePath(`${stableArray[i].a}-diff.png`), diffImage.diff);
+        fs.writeFileSync(validatePath(`${stableArray[i].a}-diff.png`, { forWriting: true }), diffImage.diff);
         console.info('Differences found');
       }
       result.urls = urls.join(' | ');