-
-
Notifications
You must be signed in to change notification settings - Fork 99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add maven dependency #591
Add maven dependency #591
Conversation
This update adds maven as a dependency to build and test the OpenJCEPlus project. As part of this effort other dependencies that were used in the past for this project have been removed. Signed-off-by: Jason Katonica <[email protected]>
This update is dependent upon adoptium/aqa-tests#5479 |
Checksum is skipped.
TKG/scripts/getDependencies.pl Line 190 in 8a8b966
I think we should do something similar to TKG/scripts/getDependencies.pl Lines 130 to 132 in 8a8b966
change shaalg => '256' to shaalg => '512'
|
Hi @llxia I attempted via commits d07ba46 and 6867f76 and a00e9f8 to directly use the SHA512 hash file published on the website ran into issues with it recognizing either the hash value or the value of the file itself. My guess is that the URL does not end in .txt and is using 512 making it different ? In the end I simply placed the sha1 hash of the file into script for validation which seems to work now when I run it:
|
Thanks for making it work. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This update adds maven as a dependency to build and test the OpenJCEPlus project. As part of this effort other dependencies that were used in the past for this project have been removed.
Signed-off-by: Jason Katonica [email protected]