Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Returning status_code in _http_post #24

Open
DanReia opened this issue Dec 23, 2020 · 0 comments
Open

Returning status_code in _http_post #24

DanReia opened this issue Dec 23, 2020 · 0 comments

Comments

@DanReia
Copy link
Contributor

DanReia commented Dec 23, 2020

We had an issue out to have _http_post return a status code however due to the fact that we are sending POST requests in batches, the returned status code will only be that of the last batch.

We should have some logic to check:

  1. If all batch status codes are the same and/or
  2. If any code matches an undesired code and/or
  3. return a full list of all status codes for all batches sent.

Additionally, we are returning a value from a private method that does not get used internally or externally. We should perhaps consider returning the status code/s from the send method as well after _http_post has been called.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant