Upd cilium v1.16.7 #653
Upd cilium v1.16.7 #653
Conversation
dosubot
bot
added
the
size:M
WalkthroughThis pull request updates the Cilium package by incrementing version numbers and container image digests from 1.16.6 to 1.16.7. It modifies multiple files including Chart.yaml, README.md, values.yaml, and the Dockerfile. Additionally, new configuration options such as Changes
Sequence Diagram(s)sequenceDiagram
participant S as Startup Script
participant K as Kubelet Service
S->>S: Perform kubelet wrapper installation
S->>S: Modify kubelet configuration
S->>S: Log "Restarting the kubelet..."
S->>K: Execute "systemctl restart kubelet"
S->>S: Continue with remaining setup
Possibly related PRs
Suggested labels
Suggested reviewers
Poem
✨ Finishing Touches
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (2)
packages/system/cilium/charts/cilium/templates/validate.yaml (1)
153-159: Clarify the New Unsafe Configuration Check
In the newly added conditional block, the code checks that the extraConfig value for"allow-unsafe-policy-skb-usage"is not set to"true"(i.e. the check(ne (index .Values.extraConfig "allow-unsafe-policy-skb-usage") "true")returns true) before applying the failure message if other buggy conditions (cluster ID range and enabled features) are met. This ensures that unless the user explicitly opts in (by setting the value to"true"), the known bug scenario is prevented.
• Please verify that this logical inversion exactly matches the intended safety requirement described in the PR objectives.
• It would be helpful to add an inline comment above the block to explain that the purpose is to force users to explicitly acknowledge the risk when enabling unsafe skb usage.packages/system/cilium/charts/cilium/values.schema.json (1)
1972-1977: Validate the NewaccessLogBufferSizeSchema Property
The new property"accessLogBufferSize"has been introduced under thelogobject to accept either anullvalue or aninteger. This correctly expands the configurability for Envoy’s access log buffer size.
• For additional robustness, consider adding numeric constraints (such as"minimum": 0) to ensure that only non-negative integers are allowed. This small enhancement can help avoid configuration errors at deployment time.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (9)
packages/system/cilium/charts/cilium/Chart.yaml(2 hunks)packages/system/cilium/charts/cilium/README.md(7 hunks)packages/system/cilium/charts/cilium/files/nodeinit/startup.bash(2 hunks)packages/system/cilium/charts/cilium/templates/cilium-configmap.yaml(1 hunks)packages/system/cilium/charts/cilium/templates/validate.yaml(1 hunks)packages/system/cilium/charts/cilium/values.schema.json(1 hunks)packages/system/cilium/charts/cilium/values.yaml(7 hunks)packages/system/cilium/charts/cilium/values.yaml.tmpl(1 hunks)packages/system/cilium/images/cilium/Dockerfile(1 hunks)
✅ Files skipped from review due to trivial changes (2)
- packages/system/cilium/images/cilium/Dockerfile
- packages/system/cilium/charts/cilium/Chart.yaml
🔇 Additional comments (16)
packages/system/cilium/charts/cilium/values.yaml.tmpl (1)
2160-2166: Improved Envoy logging configuration with new parameterThe addition of the
accessLogBufferSizeparameter enhances Envoy's logging capabilities, allowing users to configure the buffer size used for access logs. This is particularly useful for troubleshooting scenarios with large header sizes that might otherwise result in truncated messages.The default value of 4096 bytes provides a good baseline, and the documentation clearly explains when and how to adjust this value. This change aligns with best practices by making the system more configurable for different operational needs.
packages/system/cilium/charts/cilium/files/nodeinit/startup.bash (2)
119-120: Improved kubelet restart timing after wrapper installationAdding an immediate kubelet restart after the wrapper installation ensures that the new wrapper takes effect right away, rather than waiting until the end of the script.
This is a good operational improvement that makes the configuration changes more predictable by restarting the service exactly when needed.
140-141: Added explicit kubelet restart after CNI configuration changesSimilar to the previous restart command, this ensures the kubelet immediately picks up the network plugin configuration changes.
This change improves the reliability of the node initialization process by making sure configuration changes are applied promptly, reducing the chance of race conditions or missed configurations.
packages/system/cilium/charts/cilium/templates/cilium-configmap.yaml (1)
1287-1289: New Envoy Access Log Buffer Configuration BlockThis conditional block correctly checks for the presence of
.Values.envoy.log.accessLogBufferSizeand, when defined, sets theenvoy-access-log-buffer-sizekey with the value passed through thequotefilter. This approach is consistent with the pattern used for other similar parameters in the file. Please verify that the rendered (quoted) value meets the expected format (i.e. a string representation of an integer) as defined in the accompanying JSON schema.packages/system/cilium/charts/cilium/README.md (6)
3-3: Version Badges Updated
The version badges now reflect version 1.16.7. Please confirm that this change is consistent with updates in related files (e.g. Chart.yaml and values.yaml).
185-185: Updated Clustermesh API Server Image
The image configuration for the clustermesh API server has been updated with the new digest and tag v1.16.7. Ensure that this new digest is correct according to your release build and that it aligns with the corresponding image in your Chart.yaml.
356-356: Envoy Container Image Update
The envoy container image has been updated to use the new digest and tag. This ensures consistency with the current release; please verify that the repository and tag are correct for your environment.
360-360: New Envoy Log Buffer Size Option Added
A new configuration optionenvoy.log.accessLogBufferSizeis introduced with a default value of4096bytes. The description is clear and advises tuning the buffer size if truncated log messages occur. This new parameter should be cross-checked with your documentation or user guidelines to ensure compatibility with environments that have larger request/response headers.
595-595: Agent Container Image Update
The agent container image has been updated to use tag v1.16.7 along with its new digest. This update appears consistent with the overall version bump.
722-722: Cilium-Operator Image Update
The operator image configuration now includes updated digests for various clouds (AlibabaCloud, AWS, Azure, and a generic one) with tag v1.16.7. Please verify that these digests match the intended release images to ensure that the operator component will run as expected.packages/system/cilium/charts/cilium/values.yaml (6)
156-160: Cilium Agent Image Update:
The image tag has been updated to"v1.16.7"and the corresponding digest has been updated accordingly. This change ensures that the cilium-agent now references the new release version.
1316-1319: Hubble Relay Image Update:
The Hubble Relay image tag has been updated to"v1.16.7"alongside its digest, ensuring consistency with the new release. This update is essential for a synchronized upgrade of all components.
2146-2152: Envoy Access Log Buffer Size Parameter Added:
A new configuration option,accessLogBufferSize: 4096, has been introduced in the Envoy log section. This addition provides users with the ability to tune the size of the access log buffer to mitigate issues such as truncated log messages for large header sizes.
2489-2501: Cilium Operator Image Update:
The Cilium Operator image has been updated with a new tag"v1.16.7"and its related digests (generic, azure, aws, and alibabacloud) have been refreshed. These changes ensure that the operator component is aligned with the other updated components in this release.
2771-2777: Cilium Preflight Image Update:
The preflight image now uses tag"v1.16.7"and an updated digest, matching the main cilium image update. This change helps maintain consistency across deployment components and ensures compatibility in upgrade scenarios.
2920-2925: Clustermesh API Server Image Update:
The clustermesh-apiserver image has been updated to tag"v1.16.7"with an accompanying digest update. This update aligns the API server component with the overall release upgrade.
Summary by CodeRabbit
New Features
Chores