added environment variable in script and updated readme

Signed-off-by: Afreen Rahman <[email protected]>

Author: Afreen Rahman

README.md

@@ -1,7 +1,20 @@
-## Installing unreleased OCS build
+## Installing unreleased ODF build
 
 ### Requirements
  - [jq](https://stedolan.github.io/jq/) should be present
+ - Export an environment variable by name `ODF_PULL_SECRET` having the odf pull secret. 
+
+   For example:
+     
+    ```
+    # Edit bashrc
+    bash vi ~/.bashrc
+
+    #Add pull secret ODF_PULL_SECRET
+    export ODF_PULL_SECRET=<odf-pull-secret>
+    ```
+  _Note: Make sure to use `ODF_PULL_SECRET` as the name of the variable in order to get the script working_
+
 
 ### Installation
 
@@ -13,11 +26,11 @@
 2. Login to your OCP cluster
 3. Run the file as `./install-ocs.sh`
 4. Pass the token secret when asked and wait for script to finish.
-5. Go to the console > Operator hub > Storage > Choose the non-GA version to install OCS
+5. Go to the console > Operator hub > Storage > Choose the non-GA version to install ODF
 
 Note: _It can take upto 7-10 minutes to get the pull secret updated and hence the ODF catalog to appear in hub_
 
-## Installing m4.2xlarge cluster for OCS
+## Installing m4.2xlarge cluster for ODF
 
 1. Install the `openshift-installer`
 2. Create install config
@@ -37,4 +50,4 @@ Save the changes.
 ./openshift-installer create cluster --dir my-dir
 ```
 
-Note: These machines incur more cost hence use wisely. Destroy the cluster when not in use by `openshift-installer destroy cluster --dir mydir`
+_Note: These machines incur more cost hence use wisely. Destroy the cluster when not in use by `openshift-installer destroy cluster --dir mydir`_

install-ocs.sh

@@ -4,7 +4,7 @@ install_ocs() {
   echo "Updating the pull secret..."
 
   oc get -n openshift-config secret/pull-secret -ojson | jq -r '.data.".dockerconfigjson"' | base64 -d | jq > secret.json
-  jq --arg secret $PULL_SECRET '.auths."quay.io"={auth: $secret, email: ""}' secret.json > temp-secret.json
+  jq --arg secret $ODF_PULL_SECRET '.auths."quay.io"={auth: $secret, email: ""}' secret.json > temp-secret.json
   oc set data secret/pull-secret -n openshift-config --from-file=.dockerconfigjson=temp-secret.json
 
   sleep 1m
@@ -32,11 +32,6 @@ install_ocs() {
 EOF
   }
 
-echo "Enter the pull secret"
 
-read PULL_SECRET
-
-if [[ ! -z "$PULL_SECRET" ]]; then
-  install_ocs
-fi
+install_ocs