Increase backwards compatibility of moving raw bundles to `Base` modules

[MatthewDaggitt]

In commits 578e7a6 and 88942c3 we move the raw bundles from Properties to Base files.

We should publicly re-export the raw bundles in the Properties files from the Base files for backwards compatibility (putting them in the deprecation section).

[jamesmckinna]

I'll attempt to do this, but it sounds very like a 'deprecation-introduced-with-the-sole-purpose-of-being-subsequently-removed'... cf. my attempted gymnastics in trying to resolve issue #1726

... we've discussed backwards compatibility vs. breaking changes for the v2.0 milestone before, and my instincts are for the cleaner break.

But I'll see how it looks in practice.

[jamesmckinna]

And yes, I do appreciate that deprecation is designed to help client code migrate towards the Promised Land... ;-)

[MatthewDaggitt]

but it sounds very like a 'deprecation-introduced-with-the-sole-purpose-of-being-subsequently-removed'...

Yes, that is it exactly 😄

... we've discussed backwards compatibility vs. breaking changes for the v2.0 milestone before, and my instincts are for the cleaner break.

Yup I remember, but I still think where its easy for us to support backwards compatibility we should. This is only a couple of lines per file, no new imports etc.

[jamesmckinna]

Does this require an internal Bundles module declaration in Nat.Base, so that the public reexport only covers the bundles?

[MatthewDaggitt]

No. It should be as simple as adding:

open Data.Nat.Base public 
  using (+-rawMagma, ...)

to the bottom of the Data.Nat.Properties file.

[jamesmckinna]

But doesn't that make the deprecation non-local? Why not do 'the usual' of defining the original names in the deprecated section equal to their new counterparts? That way the deprecation is in the imported Properties module, not the Base module... ?

[MatthewDaggitt]

It does, but the problem is that when you're moving things, but not changing their name, then if you give the old location the same name then you're getting to get name clashes when you have both Base and Properties open....