Skip to content

[ fix ] Add correct fixities for constructor uses of _,_ #2584

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 24, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,10 @@ Bug-fixes
to `#-sym` in order to avoid overloaded projection.
`irrefl` and `cotrans` are similarly renamed for the sake of consistency.

* In `Algebra.Definitions.RawMagma` and `Relation.Binary.Construct.Interior.Symmetric`,
the record constructors `_,_` incorrectly had no declared fixity. They have been given
the fixity `infixr 4 _,_`, consistent with that of `Data.Product.Base`.

Non-backwards compatible changes
--------------------------------

Expand Down
1 change: 1 addition & 0 deletions src/Algebra/Definitions/RawMagma.agda
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@ open RawMagma M renaming (Carrier to A)
------------------------------------------------------------------------
-- Divisibility

infixr 4 _,_
infix 5 _∣ˡ_ _∤ˡ_ _∣ʳ_ _∤ʳ_ _∣_ _∤_ _∥_ _∦_

-- Divisibility from the left.
Expand Down
2 changes: 2 additions & 0 deletions src/Relation/Binary/Construct/Interior/Symmetric.agda
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,8 @@ private
------------------------------------------------------------------------
-- Definition

infixr 4 _,_

record SymInterior (R : Rel A ℓ) (x y : A) : Set ℓ where
constructor _,_
field
Expand Down