Add 2 more tests and, use more gifs (#13)

Author: PerThomasHaga

jest.config.ts

@@ -7,6 +7,9 @@ module.exports = {
   },
   transformIgnorePatterns: ["node_modules/(?!variables/.*)"],
   modulePathIgnorePatterns: ["out/"],
+  collectCoverage: true,
+  coverageDirectory: "coverage",
+  coverageReporters: ["lcov", "text-summary"],
   reporters: [
     "default",
     [

src/tests/uploadScreenshots.test.ts

@@ -50,6 +50,38 @@ describe("uploadScreenshots", () => {
     });
   });
 
+  it("handles invalid xcresultPath gracefully", async () => {
+    mockedGetApps.mockReturnValue([mockApp]);
+    mockedGetApp.mockReturnValue(mockApp);
+    process.env.FIREBASE_SERVICE_ACCOUNT = JSON.stringify({
+      type: "service_account",
+    });
+    process.env.FIREBASE_STORAGE_BUCKET = "bucket-name";
+
+    const invalidXcresultPath = "./nonexistent/path";
+    await expect(
+      uploadScreenshots(123, invalidXcresultPath, "./src/tests/exampleFiles")
+    ).rejects.toThrow("The specified xcresultPath does not exist.");
+
+    // Additional assertions can be added here
+  });
+
+  it("throws an error if the Firebase service account is corrupted", async () => {
+    // Set environment variables to undefined to simulate the missing service account
+    process.env.FIREBASE_SERVICE_ACCOUNT = undefined;
+    mockedGetApps.mockReturnValue([]);
+    await expect(
+      uploadScreenshots(123, "/path/to/xcresult", "/path/to/screenshots")
+    ).rejects.toThrow(
+      "In order to upload, you have to set FIREBASE_STORAGE_BUCKET and FIREBASE_SERVICE_ACCOUNT in the environment variables."
+    );
+
+    // Reset the environment variables after the test
+    process.env.FIREBASE_SERVICE_ACCOUNT = JSON.stringify({
+      type: "service_account",
+    });
+  });
+
   it("successfully uploads screenshots and returns download URLs", async () => {
     mockedGetApps.mockReturnValue([mockApp]);
     mockedGetApp.mockReturnValue(mockApp);

src/utils/addCommentToPR.ts

@@ -72,7 +72,7 @@ export default async (result: WriteSummaryResult) => {
 
 async function getRandomGif(search: string) {
   const httpClient = new http.HttpClient();
-  const randomNumber = Math.floor(Math.random() * 101);
+  const randomNumber = Math.floor(Math.random() * 201);
   const res = await httpClient.get(
     `https://api.giphy.com/v1/gifs/search?api_key=PFZ64SqzXhfNwVVWo6iwe1UjZzUomr1j&q=${search}&limit=1&offset=${randomNumber}&rating=g&lang=en&bundle=messaging_non_clips`
   );

src/utils/uploadScreenshots.ts

@@ -4,6 +4,7 @@ import { glob } from "glob";
 import dotenv from "dotenv";
 import * as path from "path";
 import * as util from "util";
+import * as fs from "fs";
 
 const exec = util.promisify(require("child_process").exec);
 
@@ -77,6 +78,11 @@ async function getScreenshotsFromXcresult(
   const scriptPath = path.resolve(
     `${__dirname}/../../scripts/scale_screenshots.sh`
   );
+
+  if (!fs.existsSync(xcresultPath)) {
+    throw new Error("The specified xcresultPath does not exist.");
+  }
+
   await exec("brew install imagemagick --quiet");
   await exec("brew install chargepoint/xcparse/xcparse --quiet");
   await exec(`rm -rf ${destinationPath}`);